From e19b8c05cd8b0e74eb71d577ce6239bc71717dd9 Mon Sep 17 00:00:00 2001
From: "David A. R. Robin" <david.a.r.robin@gmail.com>
Date: Mon, 24 Jun 2019 06:24:07 +0200
Subject: [PATCH] Fix crystal-lang non file-tied message handling

Some messages of the crystal compiler are not tied to a file.
This causes a 'Key not present in Dictionnary' error (E716).
For the record, the json output on ```require "./nonexistent.cr"```
is the following :
```json
  [
  { "file":"/tmp/file.cr", "line":1, "column":1, "size":0,
    "message":"while requiring \"./nonexistent.cr\"" },
  { "message":"can't find file './nonexistent.cr' relative to '/tmp'" }
  ]
```
The second message does not have line/column attributes.
---
 ale_linters/crystal/crystal.vim         |  4 ++++
 test/handler/test_crystal_handler.vader | 10 ++++++++++
 2 files changed, 14 insertions(+)

diff --git a/ale_linters/crystal/crystal.vim b/ale_linters/crystal/crystal.vim
index 3c2fefb7..8a905b12 100644
--- a/ale_linters/crystal/crystal.vim
+++ b/ale_linters/crystal/crystal.vim
@@ -5,6 +5,10 @@ function! ale_linters#crystal#crystal#Handle(buffer, lines) abort
     let l:output = []
 
     for l:error in ale#util#FuzzyJSONDecode(a:lines, [])
+        if !has_key(l:error, 'file')
+            continue
+        endif
+
         call add(l:output, {
         \   'lnum': l:error.line + 0,
         \   'col': l:error.column + 0,
diff --git a/test/handler/test_crystal_handler.vader b/test/handler/test_crystal_handler.vader
index a7b7f3ab..209632e9 100644
--- a/test/handler/test_crystal_handler.vader
+++ b/test/handler/test_crystal_handler.vader
@@ -16,3 +16,13 @@ Execute(The crystal handler should parse lines correctly and add the column if i
   \ ale_linters#crystal#crystal#Handle(255, [
   \ '[{"file":"/tmp/test.cr","line":2,"column":1,"size":null,"message":"unexpected token: EOF"}]'
   \ ])
+
+Execute(The crystal handler should not fail when a missing file is required):
+  AssertEqual
+  \ [ { 'lnum':1, 'col': 1, 'text': 'while requiring "./nonexistent.cr"' } ],
+  \ ale_linters#crystal#crystal#Handle(255,
+  \ json_encode([
+  \ { "file":"/tmp/file.cr","line":1,"column":1,"size":0,"message":"while requiring \"./nonexistent.cr\"" },
+  \ { "message": "can't find file './nonexistent.cr' relative to '/tmp'" },
+  \ ])
+  \ )