From d21581016ec7008afb00ea8e938505549a1136e9 Mon Sep 17 00:00:00 2001 From: w0rp Date: Fri, 8 Feb 2019 19:31:38 +0000 Subject: [PATCH] Fix #2257 - Fix an off by 1 which broke completion for some servers --- autoload/ale/completion.vim | 4 ++-- test/completion/test_lsp_completion_messages.vader | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/autoload/ale/completion.vim b/autoload/ale/completion.vim index d0e27cc4..8a96032e 100644 --- a/autoload/ale/completion.vim +++ b/autoload/ale/completion.vim @@ -480,8 +480,8 @@ function! s:OnReady(linter, lsp_details, ...) abort \ b:ale_completion_info.line, \ min([ \ b:ale_completion_info.line_length, - \ b:ale_completion_info.column + 1, - \ ]), + \ b:ale_completion_info.column, + \ ]) + 1, \ ale#completion#GetTriggerCharacter(&filetype, b:ale_completion_info.prefix), \) endif diff --git a/test/completion/test_lsp_completion_messages.vader b/test/completion/test_lsp_completion_messages.vader index f670e186..130f31b9 100644 --- a/test/completion/test_lsp_completion_messages.vader +++ b/test/completion/test_lsp_completion_messages.vader @@ -215,7 +215,7 @@ Execute(The right message should be sent for the initial LSP request): \ }], \ [0, 'textDocument/completion', { \ 'textDocument': {'uri': ale#path#ToURI(expand('%:p'))}, - \ 'position': {'line': 0, 'character': 2}, + \ 'position': {'line': 0, 'character': 3}, \ }], \ ], \ g:message_list @@ -274,7 +274,7 @@ Execute(Two completion requests shouldn't be sent in a row): \ }], \ [0, 'textDocument/completion', { \ 'textDocument': {'uri': ale#path#ToURI(expand('%:p'))}, - \ 'position': {'line': 0, 'character': 2}, + \ 'position': {'line': 0, 'character': 3}, \ }], \ ], \ g:message_list