From bc406a846ea6873152cfb2d6ba50456f03d7cbb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Costa?= <jdpc557@gmail.com>
Date: Fri, 1 Apr 2022 13:41:05 +0100
Subject: [PATCH] Set default value for insertTextFormat (#4124)

Co-authored-by: w0rp <devw0rp@gmail.com>
---
 autoload/ale/completion.vim                   |  2 +-
 .../test_lsp_completion_parsing.vader         | 32 +++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/autoload/ale/completion.vim b/autoload/ale/completion.vim
index 512c42f2..1c9191a1 100644
--- a/autoload/ale/completion.vim
+++ b/autoload/ale/completion.vim
@@ -581,7 +581,7 @@ function! ale#completion#ParseLSPCompletions(response) abort
             continue
         endif
 
-        if get(l:item, 'insertTextFormat') is s:LSP_INSERT_TEXT_FORMAT_PLAIN
+        if get(l:item, 'insertTextFormat', s:LSP_INSERT_TEXT_FORMAT_PLAIN) is s:LSP_INSERT_TEXT_FORMAT_PLAIN
         \&& type(get(l:item, 'textEdit')) is v:t_dict
             let l:text = l:item.textEdit.newText
         elseif type(get(l:item, 'insertText')) is v:t_string
diff --git a/test/completion/test_lsp_completion_parsing.vader b/test/completion/test_lsp_completion_parsing.vader
index a334d945..7fe22e0c 100644
--- a/test/completion/test_lsp_completion_parsing.vader
+++ b/test/completion/test_lsp_completion_parsing.vader
@@ -528,6 +528,38 @@ Execute(Should handle completion messages with textEdit objects):
   \   },
   \ })
 
+Execute(Should handle completion messages with textEdit objects and no insertTextFormat key):
+  let g:ale_completion_autoimport = 0
+
+  AssertEqual
+  \ [
+  \   {'word': 'next_callback', 'dup': 0, 'menu': 'PlayTimeCallback', 'info': '', 'kind': 'v', 'icase': 1, 'user_data': json_encode({'_ale_completion_item': 1})},
+  \ ],
+  \ ale#completion#ParseLSPCompletions({
+  \   'id': 226,
+  \   'jsonrpc': '2.0',
+  \   'result': {
+  \     'isIncomplete': v:false,
+  \     'items': [
+  \       {
+  \         'detail': 'PlayTimeCallback',
+  \         'filterText': 'next_callback',
+  \         'insertText': 'ignoreme',
+  \         'kind': 6,
+  \         'label': ' next_callback',
+  \         'sortText': '3ee19999next_callback',
+  \         'textEdit': {
+  \           'newText': 'next_callback',
+  \           'range': {
+  \             'end': {'character': 13, 'line': 12},
+  \             'start': {'character': 4, 'line': 12},
+  \           },
+  \         },
+  \       },
+  \     ],
+  \   },
+  \ })
+
 Execute(Should handle completion messages with the deprecated insertText attribute):
   let g:ale_completion_autoimport = 0