RepoMirrors/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale synced 2025-01-10 16:39:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2924 from patrick96/vlog-filename

Browse Source 
verilog: Add filename to vlog linter output
This commit is contained in:
w0rp 2020-08-14 00:20:57 +01:00 committed by GitHub
commit 94a968ef39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ale_linters/verilog/vlog.vim
View File

@ -13,14 +13,15 @@ function! ale_linters#verilog#vlog#Handle(buffer, lines) abort
"Matches patterns like the following: "Matches patterns like the following:
"** Warning: add.v(7): (vlog-2623) Undefined variable: C. "** Warning: add.v(7): (vlog-2623) Undefined variable: C.
"** Error: file.v(1): (vlog-13294) Identifier must be declared with a port mode: C. "** Error: file.v(1): (vlog-13294) Identifier must be declared with a port mode: C.
let l:pattern = '^**\s\(\w*\):[a-zA-Z0-9\-\.\_\/ ]\+(\(\d\+\)):\s\+\(.*\)' let l:pattern = '^**\s\(\w*\): \([a-zA-Z0-9\-\.\_\/ ]\+\)(\(\d\+\)):\s\+\(.*\)'
let l:output = [] let l:output = []
for l:match in ale#util#GetMatches(a:lines, l:pattern) for l:match in ale#util#GetMatches(a:lines, l:pattern)
call add(l:output, { call add(l:output, {
\ 'lnum': l:match[2] + 0, \ 'lnum': l:match[3] + 0,
\ 'type': l:match[1] is? 'Error' ? 'E' : 'W', \ 'type': l:match[1] is? 'Error' ? 'E' : 'W',
\ 'text': l:match[3], \ 'text': l:match[4],
\ 'filename': l:match[2],
\}) \})
endfor endfor
@ -28,13 +29,14 @@ function! ale_linters#verilog#vlog#Handle(buffer, lines) abort
"** Warning: (vlog-2623) add.v(7): Undefined variable: C. "** Warning: (vlog-2623) add.v(7): Undefined variable: C.
"** Error: (vlog-13294) file.v(1): Identifier must be declared with a port mode: C. "** Error: (vlog-13294) file.v(1): Identifier must be declared with a port mode: C.
" let l:pattern = '^**\s\(\w*\):[a-zA-Z0-9\-\.\_\/ ]\+(\(\d\+\)):\s\+\(.*\)' " let l:pattern = '^**\s\(\w*\):[a-zA-Z0-9\-\.\_\/ ]\+(\(\d\+\)):\s\+\(.*\)'
let l:pattern = '^**\s\(\w*\):\s\([^)]*)\)[a-zA-Z0-9\-\.\_\/ ]\+(\(\d\+\)):\s\+\(.*\)' let l:pattern = '^**\s\(\w*\):\s\([^)]*)\) \([a-zA-Z0-9\-\.\_\/ ]\+\)(\(\d\+\)):\s\+\(.*\)'
for l:match in ale#util#GetMatches(a:lines, l:pattern) for l:match in ale#util#GetMatches(a:lines, l:pattern)
call add(l:output, { call add(l:output, {
\ 'lnum': l:match[3] + 0, \ 'lnum': l:match[4] + 0,
\ 'type': l:match[1] is? 'Error' ? 'E' : 'W', \ 'type': l:match[1] is? 'Error' ? 'E' : 'W',
\ 'text': l:match[2] . ' ' . l:match[4], \ 'text': l:match[2] . ' ' . l:match[5],
\ 'filename': l:match[3],
\}) \})
endfor endfor

12
test/handler/test_vlog_handler.vader
View File

@ -10,12 +10,14 @@ Execute(The vlog handler should parse old-style lines correctly):
\ { \ {
\ 'lnum': 7, \ 'lnum': 7,
\ 'type': 'W', \ 'type': 'W',
\ 'text': '(vlog-2623) Undefined variable: C.' \ 'text': '(vlog-2623) Undefined variable: C.',
\ 'filename': 'add.v'
\ }, \ },
\ { \ {
\ 'lnum': 1, \ 'lnum': 1,
\ 'type': 'E', \ 'type': 'E',
\ 'text': '(vlog-13294) Identifier must be declared with a port mode: C.' \ 'text': '(vlog-13294) Identifier must be declared with a port mode: C.',
\ 'filename': 'file.v'
\ }, \ },
\ ], \ ],
\ ale_linters#verilog#vlog#Handle(bufnr(''), [ \ ale_linters#verilog#vlog#Handle(bufnr(''), [
@ -29,12 +31,14 @@ Execute(The vlog handler should parse new-style lines correctly):
\ { \ {
\ 'lnum': 7, \ 'lnum': 7,
\ 'type': 'W', \ 'type': 'W',
\ 'text': '(vlog-2623) Undefined variable: C.' \ 'text': '(vlog-2623) Undefined variable: C.',
\ 'filename': 'add.v'
\ }, \ },
\ { \ {
\ 'lnum': 1, \ 'lnum': 1,
\ 'type': 'E', \ 'type': 'E',
\ 'text': '(vlog-13294) Identifier must be declared with a port mode: C.' \ 'text': '(vlog-13294) Identifier must be declared with a port mode: C.',
\ 'filename': 'file.v'
\ }, \ },
\ ], \ ],
\ ale_linters#verilog#vlog#Handle(bufnr(''), [ \ ale_linters#verilog#vlog#Handle(bufnr(''), [