From 8632e6b4e038178fd367aade1fa213dd93845af5 Mon Sep 17 00:00:00 2001 From: Edward Larkey Date: Sun, 30 Oct 2016 13:23:32 -0500 Subject: [PATCH] Added support for foodcritic Adding support the foodcritic linter for Chef files. Listing all issues as warnings for now Doesn't get in the way of rubocop linting if ft=ruby.chef Updated documentation Closes #127 --- README.md | 1 + ale_linters/chef/foodcritic.vim | 41 +++++++++++++++++++++++++++++++++ doc/ale.txt | 1 + 3 files changed, 43 insertions(+) create mode 100644 ale_linters/chef/foodcritic.vim diff --git a/README.md b/README.md index 4b98a885..d42ffaf9 100644 --- a/README.md +++ b/README.md @@ -52,6 +52,7 @@ name. That seems to be the fairest way to arrange this table. | Bourne Shell | [-n flag](http://linux.die.net/man/1/sh), [shellcheck](https://www.shellcheck.net/) | | C | [cppcheck](http://cppcheck.sourceforge.net), [gcc](https://gcc.gnu.org/), [clang](http://clang.llvm.org/)| | C++ (filetype cpp) | [cppcheck] (http://cppcheck.sourceforge.net), [gcc](https://gcc.gnu.org/)| +| Chef | [foodcritic](http://www.foodcritic.io/) | | CoffeeScript | [coffee](http://coffeescript.org/), [coffeelint](https://www.npmjs.com/package/coffeelint) | | CSS | [csslint](http://csslint.net/) | | Cython (pyrex filetype) | [cython](http://cython.org/) | diff --git a/ale_linters/chef/foodcritic.vim b/ale_linters/chef/foodcritic.vim new file mode 100644 index 00000000..35f5c9b5 --- /dev/null +++ b/ale_linters/chef/foodcritic.vim @@ -0,0 +1,41 @@ +" Author: Edward Larkey +" Description: This file adds the foodcritic linter for Chef files. + +function! ale_linters#chef#foodcritic#Handle(buffer, lines) + " Matches patterns line the following: + " + " FC002: Avoid string interpolation where not required: httpd.rb:13 + let l:pattern = '^\(.\+:\s.\+\):\s\(.\+\):\(\d\+\)$' + let l:output = [] + + for l:line in a:lines + let l:match = matchlist(l:line, l:pattern) + + if len(l:match) == 0 + continue + endif + + let l:text = l:match[1] + + " vcol is Needed to indicate that the column is a character. + call add(l:output, { + \ 'bufnr': a:buffer, + \ 'lnum': l:match[3] + 0, + \ 'vcol': 0, + \ 'col': 0, + \ 'text': l:text, + \ 'type': 'W', + \ 'nr': -1, + \}) + endfor + + return l:output +endfunction + +call ale#linter#Define('chef', { +\ 'name': 'foodcritic', +\ 'executable': 'foodcritic', +\ 'command': g:ale#util#stdin_wrapper . ' .rb foodcritic', +\ 'callback': 'ale_linters#chef#foodcritic#Handle', +\}) + diff --git a/doc/ale.txt b/doc/ale.txt index 1efa9ab9..71ccb40a 100644 --- a/doc/ale.txt +++ b/doc/ale.txt @@ -58,6 +58,7 @@ The following languages and tools are supported. * Bourne Shell: 'shell' (-n flag), 'shellcheck' * C: 'cppcheck', 'gcc', 'clang' * C++ (filetype cpp): 'cppcheck', 'gcc' +* Chef: 'foodcritic' * CoffeeScript: 'coffee', 'coffelint' * CSS: 'csslint' * Cython (pyrex filetype): 'cython'