RepoMirrors
/
ale
mirror of https://github.com/dense-analysis/ale
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

support ember-template-lint 4.x (#4200) 

* support ember-template-lint 4.x

* update ember-template-lint linter test
This commit is contained in:
James C. Davis 2022-05-14 23:44:23 -04:00 committed by GitHub
parent e6ca599e87
commit 5479b58660
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ale_linters/handlebars/embertemplatelint.vim
View File

@ -11,10 +11,17 @@ function! ale_linters#handlebars#embertemplatelint#GetExecutable(buffer) abort
endfunction endfunction
function! ale_linters#handlebars#embertemplatelint#GetCommand(buffer, version) abort function! ale_linters#handlebars#embertemplatelint#GetCommand(buffer, version) abort
if ale#semver#GTE(a:version, [4, 0, 0])
" --json was removed in favor of --format=json in ember-template-lint@4.0.0
return '%e --format=json --filename %s'
endif
if ale#semver#GTE(a:version, [1, 6, 0])
" Reading from stdin was introduced in ember-template-lint@1.6.0 " Reading from stdin was introduced in ember-template-lint@1.6.0
return ale#semver#GTE(a:version, [1, 6, 0]) return '%e --json --filename %s'
\ ? '%e --json --filename %s' endif
\ : '%e --json %t'
return '%e --json %t'
endfunction endfunction
function! ale_linters#handlebars#embertemplatelint#GetCommandWithVersionCheck(buffer) abort function! ale_linters#handlebars#embertemplatelint#GetCommandWithVersionCheck(buffer) abort

16
test/linter/test_embertemplatelint.vader
View File

@ -1,17 +1,23 @@
Before: Before:
call ale#assert#SetUpLinterTest('handlebars', 'embertemplatelint') call ale#assert#SetUpLinterTest('handlebars', 'embertemplatelint')
GivenCommandOutput ['1.6.0']
After: After:
call ale#assert#TearDownLinterTest() call ale#assert#TearDownLinterTest()
Execute(ember-template-lint executables runs the right command): Execute(Runs the right command for ember-template-lint >= 4.x):
GivenCommandOutput ['4.0.0']
AssertLinter 'ember-template-lint',
\ ale#Escape('ember-template-lint') . ' --format=json --filename %s'
Execute(Runs the right command for ember-template-lint >= 1.6, < 4.x):
GivenCommandOutput ['1.6.0']
AssertLinter 'ember-template-lint', AssertLinter 'ember-template-lint',
\ ale#Escape('ember-template-lint') . ' --json --filename %s' \ ale#Escape('ember-template-lint') . ' --json --filename %s'
Execute(old ember-template-lint executables runs the right command): Execute(Runs the right command for ember-template-lint < 1.6):
GivenCommandOutput [] GivenCommandOutput ['1.5.0']
AssertLinter 'ember-template-lint', AssertLinter 'ember-template-lint',
\ ale#Escape('ember-template-lint') . ' --json %t' \ ale#Escape('ember-template-lint') . ' --json %t'