From 4fa66ab627039fe19cf6383b19d311066b73d8cf Mon Sep 17 00:00:00 2001
From: w0rp <devw0rp@gmail.com>
Date: Sun, 16 Jul 2017 01:15:07 +0100
Subject: [PATCH] Fix #560 #763 - Silence errors for setting signs, and do
 nothing for dirvish

---
 autoload/ale/sign.vim | 8 ++++----
 plugin/ale.vim        | 8 +++++++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/autoload/ale/sign.vim b/autoload/ale/sign.vim
index eee1027b..37105f9f 100644
--- a/autoload/ale/sign.vim
+++ b/autoload/ale/sign.vim
@@ -65,7 +65,7 @@ sign define ALEDummySign
 " Read sign data for a buffer to a list of lines.
 function! ale#sign#ReadSigns(buffer) abort
     redir => l:output
-       silent exec 'sign place buffer=' . a:buffer
+       silent execute 'sign place buffer=' . a:buffer
     redir end
 
     return split(l:output, "\n")
@@ -154,7 +154,7 @@ function! s:SetDummySignIfNeeded(buffer, current_sign_list, new_signs) abort
     " If we haven't already set a dummy sign, and we have some previous signs
     " or always want a dummy sign, then set one, to keep the sign column open.
     if !l:is_dummy_sign_set && (a:new_signs || g:ale_sign_column_always)
-        execute 'sign place ' .  g:ale_sign_offset
+        silent! execute 'sign place ' .  g:ale_sign_offset
         \   . ' line=1 name=ALEDummySign buffer='
         \   . a:buffer
 
@@ -223,7 +223,7 @@ function! s:PlaceNewSigns(buffer, grouped_items, current_sign_offset) abort
             let l:obj.sign_id = l:sign_id
         endfor
 
-        execute 'sign place ' . l:sign_id
+        silent! execute 'sign place ' . l:sign_id
         \   . ' line=' . l:sublist[0].lnum
         \   . ' name=' . l:type
         \   . ' buffer=' . a:buffer
@@ -295,7 +295,7 @@ function! ale#sign#SetSigns(buffer, loclist) abort
     for [l:line, l:sign_id, l:name] in l:current_sign_list
         if l:sign_id != g:ale_sign_offset
         \&& !has_key(l:items_by_sign_id, l:sign_id)
-            exec 'sign unplace ' . l:sign_id . ' buffer=' . a:buffer
+            execute 'sign unplace ' . l:sign_id . ' buffer=' . a:buffer
         endif
     endfor
 
diff --git a/plugin/ale.vim b/plugin/ale.vim
index 0fbfcb17..dc9b93ee 100644
--- a/plugin/ale.vim
+++ b/plugin/ale.vim
@@ -55,7 +55,13 @@ let g:ale_buffer_info = {}
 
 " This option prevents ALE autocmd commands from being run for particular
 " filetypes which can cause issues.
-let g:ale_filetype_blacklist = ['nerdtree', 'unite', 'tags', 'qf']
+let g:ale_filetype_blacklist = [
+\   'dirvish',
+\   'nerdtree',
+\   'qf',
+\   'tags',
+\   'unite',
+\]
 
 " This Dictionary configures which linters are enabled for which languages.
 let g:ale_linters = get(g:, 'ale_linters', {})