Allow to pass options to the buf linter and fix callback. (#4300)

* Allow to pass options to the buf linter

* Fix the callback of buf linter
This commit is contained in:
Guangqing Chen 2022-09-08 16:04:17 +08:00 committed by GitHub
parent e99f262c2f
commit 477ad3fdd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions

View File

@ -3,12 +3,15 @@
call ale#Set('proto_buf_lint_executable', 'buf')
call ale#Set('proto_buf_lint_config', '')
call ale#Set('proto_buf_lint_options', '')
function! ale_linters#proto#buf_lint#GetCommand(buffer) abort
let l:config = ale#Var(a:buffer, 'proto_buf_lint_config')
let l:options = ale#Var(a:buffer, 'proto_buf_lint_options')
return '%e lint'
\ . (!empty(l:config) ? ' --config=' . ale#Escape(l:config) : '')
\ . (!empty(l:options) ? ' ' . l:options : '')
\ . ' %s#include_package_files=true'
endfunction
@ -19,5 +22,5 @@ call ale#linter#Define('proto', {
\ 'output_stream': 'stdout',
\ 'executable': {b -> ale#Var(b, 'proto_buf_lint_executable')},
\ 'command': function('ale_linters#proto#buf_lint#GetCommand'),
\ 'callback': 'ale#handlers#unix#HandleAsError',
\ 'callback': 'ale#handlers#go#Handler',
\})

View File

@ -11,7 +11,7 @@ Execute(The default command should be correct):
\ . ' lint'
\ . ' %s#include_package_files=true'
Execute(The callback should include any additional options):
Execute(The callback should include any additional config):
let b:ale_proto_buf_lint_executable = '/tmp/buf'
let b:ale_proto_buf_lint_config = '/tmp/buf.yaml'
@ -20,3 +20,13 @@ Execute(The callback should include any additional options):
\ . ' lint'
\ . ' --config=' . ale#Escape('/tmp/buf.yaml')
\ . ' %s#include_package_files=true'
Execute(The callback should include additional options):
let b:ale_proto_buf_lint_executable = '/tmp/buf'
let b:ale_proto_buf_lint_options = '--disable-symlinks'
AssertLinter '/tmp/buf',
\ ale#Escape('/tmp/buf')
\ . ' lint'
\ . ' --disable-symlinks'
\ . ' %s#include_package_files=true'