RepoMirrors
/
ale
mirror of https://github.com/dense-analysis/ale
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

address PR feedback by fixing docs and hardcoding bash to use -c on fish and pwsh environments

This commit is contained in:
Holden 2018-12-28 12:35:57 -05:00
parent c499825a0b
commit 3ec20a730d
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
autoload/ale/job.vim
View File

@ -195,7 +195,7 @@ function! ale#job#PrepareCommand(buffer, command) abort
endif endif
if g:ale_shell =~? 'fish$\|pwsh$' if g:ale_shell =~? 'fish$\|pwsh$'
return ['/bin/sh', g:ale_shell_arguments, l:command] return ['/bin/sh', '-c', l:command]
endif endif
return [g:ale_shell] + split(g:ale_shell_arguments) + [l:command] return [g:ale_shell] + split(g:ale_shell_arguments) + [l:command]

9
doc/ale.txt
View File

@ -1999,6 +1999,12 @@ g:ale_shell *g:ale_shell*
commands. This variables defaults to the value of the vim option '&shell' commands. This variables defaults to the value of the vim option '&shell'
which corresponds to the $SHELL environment variable. For example which corresponds to the $SHELL environment variable. For example
if `$SHELL == '/bin/bash'`, but you want to use zsh, set `g:ale_shell = '/bin/zsh'.` if `$SHELL == '/bin/bash'`, but you want to use zsh, set `g:ale_shell = '/bin/zsh'.`
If this option is set to either `fish` or `pwsh` (either by default or set
with this command), ale will still execute commands with `bin/sh`.
Please note - if you are using this option you should consider additionally
setting `g:ale``g:ale_shell_arguments` since the default values for that
option might be incompatable with the newly set shell.
g:ale_shell_arguments *g:ale_shell_arguments* g:ale_shell_arguments *g:ale_shell_arguments*
@ -2007,7 +2013,8 @@ g:ale_shell_arguments *g:ale_shell_arguments*
This variable is used to determine what commands vim will pass to the shell This variable is used to determine what commands vim will pass to the shell
to execute it's commands. By default, `&shellcmdflag` would be set to the to execute it's commands. By default, `&shellcmdflag` would be set to the
value of '`-c'`. value of '`-c'`. Similar to `g:ale_shell`, if the shell is set to either
`fish` or `pwsh`, `g:ale_shell_arguments` will no be used.
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
6.1. Highlights *ale-highlights* 6.1. Highlights *ale-highlights*