RepoMirrors
/
ale
mirror of https://github.com/dense-analysis/ale
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Properly handle optional end_line_no/end_line_pos in sqlfluff (#4867) 

end_line_no/end_line_pos are optional. Example SQL:
`SELECT NULL FROM {{ a_jinja_templated_table }};`

`sqlfluff lint --dialect ansi --format json` gives the following error
among others:
```
{"start_line_no": 1, "start_line_pos": 21, "code": "TMP", "description":
"Undefined jinja template variable: 'a_jinja_templated_table'", "name":
"", "warning": false}
```

As one can see there is no end_line_no/end_line_pos.
This commit is contained in:
Coacher 2024-11-27 16:17:02 +03:00 committed by GitHub
parent 9d30fb2f59
commit 0ef2c455ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ale_linters/sql/sqlfluff.vim
View File

@ -52,16 +52,24 @@ function! ale_linters#sql#sqlfluff#Handle(buffer, version, lines) abort
if ale#semver#GTE(a:version, [3, 0, 0])
for l:violation in get(l:json, 'violations', [])
call add(l:output, {
let l:err = {
\ 'filename': l:json.filepath,
\ 'lnum': l:violation.start_line_no,
\ 'end_lnum': l:violation.end_line_no,
\ 'col': l:violation.start_line_pos,
\ 'end_col': l:violation.end_line_pos,
\ 'text': l:violation.description,
\ 'code': l:violation.code,
\ 'type': 'W',
\})
\}
if has_key(l:violation, 'end_line_no')
let l:err.end_lnum = l:violation.end_line_no
endif
if has_key(l:violation, 'end_line_pos')
let l:err.end_col = l:violation.end_line_pos
endif
call add(l:output, l:err)
endfor
else
for l:violation in get(l:json, 'violations', [])

10
test/handler/test_sql_sqlfluff_handler.vader
View File

@ -69,7 +69,15 @@ Execute(The sqlfluff handler should handle basic warnings with version newer tha
\ 'code': 'L009',
\ 'text': 'Files must end with a single trailing newline.',
\ },
\ {
\ 'filename': 'schema.sql',
\ 'lnum': 3,
\ 'col': 21,
\ 'type': 'W',
\ 'code': 'TMP',
\ 'text': "Undefined jinja template variable: 'a_jinja_templated_table'",
\ },
\ ],
\ ale_linters#sql#sqlfluff#Handle(bufnr(''), [3, 0, 0], [
\ '[{"filepath": "schema.sql", "violations": [{"start_line_no": 1, "end_line_no":1, "start_line_pos": 8, "end_line_pos":12, "code": "L010", "description": "Keywords must be consistently upper case."}, {"start_line_no": 13, "end_line_no":13, "start_line_pos": 2, "end_line_pos":20, "code": "L003", "description": "Expected 1 indentation, found 0 [compared to line 12]"}, {"start_line_no": 16, "end_line_no":16, "start_line_pos": 1, "end_line_pos":5, "code": "L009", "description": "Files must end with a single trailing newline."}]}]',
\ '[{"filepath": "schema.sql", "violations": [{"start_line_no": 1, "end_line_no":1, "start_line_pos": 8, "end_line_pos":12, "code": "L010", "description": "Keywords must be consistently upper case."}, {"start_line_no": 13, "end_line_no":13, "start_line_pos": 2, "end_line_pos":20, "code": "L003", "description": "Expected 1 indentation, found 0 [compared to line 12]"}, {"start_line_no": 16, "end_line_no":16, "start_line_pos": 1, "end_line_pos":5, "code": "L009", "description": "Files must end with a single trailing newline."}, {"start_line_no": 3, "start_line_pos": 21, "code": "TMP", "description": "Undefined jinja template variable: ''a_jinja_templated_table''"}]}]',
\ ])