2016-10-06 09:11:19 +00:00
|
|
|
" Author: jwilliams108 <https://github.com/jwilliams108>
|
|
|
|
" Description: phpcs for PHP files
|
|
|
|
|
|
|
|
if exists('g:loaded_ale_linters_php_phpcs')
|
|
|
|
finish
|
|
|
|
endif
|
|
|
|
|
|
|
|
let g:loaded_ale_linters_php_phpcs = 1
|
|
|
|
|
|
|
|
function! ale_linters#php#phpcs#GetCommand(buffer)
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:command = 'phpcs -s --report=emacs --stdin-path=%s'
|
2016-10-06 09:11:19 +00:00
|
|
|
|
|
|
|
" This option can be set to change the standard used by phpcs
|
2016-10-07 00:03:19 +00:00
|
|
|
if exists('g:ale_php_phpcs_standard')
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:command .= ' --standard=' . g:ale_php_phpcs_standard
|
2016-10-06 09:11:19 +00:00
|
|
|
endif
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
return l:command
|
2016-10-06 09:11:19 +00:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#php#phpcs#Handle(buffer, lines)
|
|
|
|
" Matches against lines like the following:
|
|
|
|
"
|
|
|
|
" /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) - \(.\+\) \(\(.\+\)\)$'
|
|
|
|
let l:output = []
|
2016-10-06 09:11:19 +00:00
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
for l:line in a:lines
|
|
|
|
let l:match = matchlist(l:line, l:pattern)
|
2016-10-06 09:11:19 +00:00
|
|
|
|
|
|
|
if len(l:match) == 0
|
|
|
|
continue
|
|
|
|
endif
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:text = l:match[4]
|
|
|
|
let l:type = l:match[3]
|
2016-10-06 09:11:19 +00:00
|
|
|
|
|
|
|
" vcol is Needed to indicate that the column is a character.
|
2016-10-10 23:43:45 +00:00
|
|
|
call add(l:output, {
|
2016-10-06 09:11:19 +00:00
|
|
|
\ 'bufnr': a:buffer,
|
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'vcol': 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
2016-10-10 23:43:45 +00:00
|
|
|
\ 'text': l:text,
|
|
|
|
\ 'type': l:type ==# 'warning' ? 'W' : 'E',
|
2016-10-06 09:11:19 +00:00
|
|
|
\ 'nr': -1,
|
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
return l:output
|
2016-10-06 09:11:19 +00:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('php', {
|
2016-10-06 09:11:19 +00:00
|
|
|
\ 'name': 'phpcs',
|
|
|
|
\ 'executable': 'phpcs',
|
|
|
|
\ 'command_callback': 'ale_linters#php#phpcs#GetCommand',
|
|
|
|
\ 'callback': 'ale_linters#php#phpcs#Handle',
|
|
|
|
\})
|