RepoMirrors
/
ale
mirror of https://github.com/dense-analysis/ale
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ale/test/handler/test_checkstyle_handler.vader

50 lines
1.6 KiB
Plaintext
Raw Normal View History

Clean up linters after running the checkstyle handlers
2017-05-15 19:59:50 +00:00
Before:
Add checkstyle linter
2017-05-12 13:42:32 +00:00
runtime ale_linters/java/checkstyle.vim
Clean up linters after running the checkstyle handlers
2017-05-15 19:59:50 +00:00
After:
call ale#linter#Reset()
Execute(The checkstyle handler should parse lines correctly):
Add checkstyle linter
2017-05-12 13:42:32 +00:00
AssertEqual
\ [
\ {
\ 'lnum': 101,
#852 - Capture error codes for checkstyle
2017-11-18 18:29:12 +00:00
\ 'col': 0,
\ 'text': '''method def rcurly'' has incorrect indentation level 4, expected level should be 2.',
\ 'code': 'Indentation',
Add checkstyle linter
2017-05-12 13:42:32 +00:00
\ 'type': 'W',
\ },
\ {
\ 'lnum': 63,
\ 'col': 3,
#852 - Capture error codes for checkstyle
2017-11-18 18:29:12 +00:00
\ 'text': 'Missing a Javadoc comment.',
\ 'code': 'JavadocMethod',
Add checkstyle linter
2017-05-12 13:42:32 +00:00
\ 'type': 'W',
\ },
Fix java checkstyle handler. The checkstyle handler is capable of parsing the new and old output formats. Unfortunately there are some particular output messages that matched both the new and old regular expressions: [WARN] whatever:11:7: WhitespaceAround: ''if'' is not followed by whitespace. [WhitespaceAround] This caused ALE to report extra errors since the message was being matched twice, once as a warning and another (incorrect) old formatted error. This MR fixes this by stopping any parsing using the old format regexp is any errors of the new format are correcly parsed. There is no reason to expect checkstyle to output both styles in the same report.
2019-05-28 08:48:27 +00:00
\ {
\ 'lnum': 11,
\ 'col': 7,
\ 'text': 'WhitespaceAround: ''if'' is not followed by whitespace.',
\ 'code': 'WhitespaceAround',
\ 'type': 'W',
\ },
Add checkstyle linter
2017-05-12 13:42:32 +00:00
\ ],
\ ale_linters#java#checkstyle#Handle(666, [
#852 - Capture error codes for checkstyle
2017-11-18 18:29:12 +00:00
\ '[WARN] whatever:101: ''method def rcurly'' has incorrect indentation level 4, expected level should be 2. [Indentation]',
\ '[WARN] whatever:63:3: Missing a Javadoc comment. [JavadocMethod]',
Fix java checkstyle handler. The checkstyle handler is capable of parsing the new and old output formats. Unfortunately there are some particular output messages that matched both the new and old regular expressions: [WARN] whatever:11:7: WhitespaceAround: ''if'' is not followed by whitespace. [WhitespaceAround] This caused ALE to report extra errors since the message was being matched twice, once as a warning and another (incorrect) old formatted error. This MR fixes this by stopping any parsing using the old format regexp is any errors of the new format are correcly parsed. There is no reason to expect checkstyle to output both styles in the same report.
2019-05-28 08:48:27 +00:00
\ '[WARN] whatever:11:7: WhitespaceAround: ''if'' is not followed by whitespace. [WhitespaceAround]',
Add checkstyle linter
2017-05-12 13:42:32 +00:00
\ ])
Support older checkstyle versions The output format used by older checkstyle versions differs from the one of new versions. This commit adds a second parsing iteration on the output lines with a suitable pattern to support both versions in parallel. Due to the differences in the order of matching groups this is hard to achieve in a single pass through the output lines. An appropriate test case is added.
2018-11-07 12:25:48 +00:00
Execute(The checkstyle handler should parse lines from older checkstyle versions correctly):
AssertEqual
\ [
\ {
\ 'lnum': 289,
\ 'text': '''method def modifier'' have incorrect indentation level 4, expected level should be 2.',
\ 'type': 'W',
\ },
\ ],
\ ale_linters#java#checkstyle#Handle(666, [
\ '/home/languitar/src/rsb-java/rsb-java/src/main/java/rsb/Listener.java:289: warning: ''method def modifier'' have incorrect indentation level 4, expected level should be 2.',
\ ])