RepoMirrors
/
ale
mirror of https://github.com/dense-analysis/ale
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ale/test/fixers/test_standardrb_fixer_callb...

52 lines
1.8 KiB
Plaintext
Raw Normal View History

Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
Before:
Save g:ale_ruby_standardrb_executable
Save g:ale_ruby_standardrb_options
" Use an invalid global executable, so we don't match it.
let g:ale_ruby_standardrb_executable = 'xxxinvalid'
let g:ale_ruby_standardrb_options = ''
call ale#test#SetDirectory('/testplugin/test/fixers')
After:
Restore
call ale#test#RestoreDirectory()
Execute(The standardrb callback should return the correct default values):
#3633 - Put all dummy test files in test/test-files
2021-03-20 22:11:22 +00:00
call ale#test#SetFilename('../test-files/ruby/dummy.rb')
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
AssertEqual
\ {
Update tests
2021-01-06 02:07:41 +00:00
\ 'process_with': 'ale#fixers#rubocop#PostProcess',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ 'command': ale#Escape(g:ale_ruby_standardrb_executable)
Update tests
2021-01-06 02:07:41 +00:00
\ . ' --fix --force-exclusion --stdin %s',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ },
\ ale#fixers#standardrb#Fix(bufnr(''))
Execute(The standardrb callback should include configuration files):
#3633 - Put all dummy test files in test/test-files
2021-03-20 22:11:22 +00:00
call ale#test#SetFilename('../test-files/ruby/with_config/dummy.rb')
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
AssertEqual
\ {
Update tests
2021-01-06 02:07:41 +00:00
\ 'process_with': 'ale#fixers#rubocop#PostProcess',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ 'command': ale#Escape(g:ale_ruby_standardrb_executable)
#3633 - Put all dummy test files in test/test-files
2021-03-20 22:11:22 +00:00
\ . ' --config ' . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/ruby/with_config/.standard.yml'))
Update tests
2021-01-06 02:07:41 +00:00
\ . ' --fix --force-exclusion --stdin %s',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ },
\ ale#fixers#standardrb#Fix(bufnr(''))
Execute(The standardrb callback should include custom rubocop options):
let g:ale_ruby_standardrb_options = '--except Lint/Debugger'
#3633 - Put all dummy test files in test/test-files
2021-03-20 22:11:22 +00:00
call ale#test#SetFilename('../test-files/ruby/with_config/dummy.rb')
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
AssertEqual
\ {
Update tests
2021-01-06 02:07:41 +00:00
\ 'process_with': 'ale#fixers#rubocop#PostProcess',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ 'command': ale#Escape(g:ale_ruby_standardrb_executable)
#3633 - Put all dummy test files in test/test-files
2021-03-20 22:11:22 +00:00
\ . ' --config ' . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/ruby/with_config/.standard.yml'))
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ . ' --except Lint/Debugger'
Update tests
2021-01-06 02:07:41 +00:00
\ . ' --fix --force-exclusion --stdin %s',
Adds standardrb linter (#2133) See: https://github.com/testdouble/standard StandardRB is to RuboCop what StandardJS is to ESLint. This commit naively copies the RuboCop linter and fixer to point at the standardrb executable. Any other adjustments are very minor (the only I can think of is that standardrb takes a `--fix` option instead of `--auto-correct`). This raises a confusing point to me as both developer and a user: since ale enables all linters by default, won't this run both RuboCop and StandardRB (the results of which will almost always be in conflict with one another)? How does ale already solve for this for the similar case of StandardJS and ESLint?
2018-12-10 21:02:32 +00:00
\ },
\ ale#fixers#standardrb#Fix(bufnr(''))