RepoMirrors/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale synced 2024-12-18 04:15:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
26e61fad69
ale/test/test_c_flag_parsing.vader

369 lines
16 KiB
Plaintext
Raw Normal View History

Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
Before:
Save g:ale_c_parse_makefile
call ale#test#SetDirectory('/testplugin/test')
let g:ale_c_parse_makefile = 1
After:
Restore
call ale#test#RestoreDirectory()
Execute(The CFlags parser should be able to parse include directives):
call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir')),
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -Isubdir -c file.c'])
Parse more C/C++ compiler options
2019-01-22 02:45:17 +00:00
AssertEqual
\ '-isystem ' . '/usr/include/dir',
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -isystem /usr/include/dir -c file.c'])
Execute(ParseCFlags should ignore -c and -o):
call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir')),
Parse more C/C++ compiler options
2019-01-22 02:45:17 +00:00
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -Isubdir -c file.c -o a.out'])
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
Execute(The CFlags parser should be able to parse macro directives):
call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=1',
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -Isubdir -DTEST=1 -c file.c'])
Execute(The CFlags parser should be able to parse macro directives with spaces):
call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=$(( 2 * 4 ))',
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -Isubdir -DTEST=$(( 2 * 4 )) -c file.c'])
Execute(The CFlags parser should be able to parse shell directives with spaces):
call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlagsFromMakeOutput(bufnr(''), ['gcc -Isubdir -DTEST=`date +%s` -c file.c'])
Execute(ParseCFlags should be able to parse flags with relative paths):
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc -Isubdir '
\ . '-I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Execute(ParseCFlags should be able to parse -Dgoal):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc -Dgoal=9 -Isubdir '
\ . '-I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
Execute(ParseCFlags should ignore -T and other arguments):
AssertEqual
\ '-Dgoal=9'
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '--sysroot=subdir'
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir --sysroot=subdir '
\ . '-I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
Execute(ParseCFlags should handle paths with spaces in double quotes):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . '-I"dir with spaces"' . ' -I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Execute(ParseCFlags should handle paths with spaces in single quotes):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
\ . '-I''dir with spaces''' . ' -I'. ale#path#Simplify('kernel/include')
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Execute(ParseCFlags should handle paths with minuses):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir-with-dash'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
\ . '-I''dir with spaces''' . ' -Idir-with-dash'
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Execute(ParseCFlags should handle -D with minuses):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -Dmacro-with-dash'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir-with-dash'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -DTEST=`date +%s`',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . '-Dmacro-with-dash '
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . '-I''dir with spaces''' . ' -Idir-with-dash'
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ . ' -I'. ale#path#Simplify('kernel/include')
\ . ' -DTEST=`date +%s` -c file.c'
\ )
Fix bug where last c flag was ignored There is currently a check that tries to prevent c-flags that contain '-' in them from being unintentionally split and included in the list of commands. For example, we wouldn't want "-fno-exceptions " to appear as "-fno" and "-exceptions ". The way this check was done was by making sure the last character of the split string was a space. This meant that the very last option to appear in the compile command was ignored (as it doesn't end with a space). This fix explicitly skips the ends-with-space check on the last option in the command-line. This isn't the best fix. Really we should be using the same argument-processing rules as a shell would rather than just splitting on '-'. That's a much larger and more complicated change though.
2018-09-11 01:46:18 +00:00
Execute(ParseCFlags should handle flags at the end of the line):
AssertEqual
\ '-Dgoal=9'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' -Dmacro-with-dash'
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir-with-dash'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include')),
Fix bug where last c flag was ignored There is currently a check that tries to prevent c-flags that contain '-' in them from being unintentionally split and included in the list of commands. For example, we wouldn't want "-fno-exceptions " to appear as "-fno" and "-exceptions ". The way this check was done was by making sure the last character of the split string was a space. This meant that the very last option to appear in the compile command was ignored (as it doesn't end with a space). This fix explicitly skips the ends-with-space check on the last option in the command-line. This isn't the best fix. Really we should be using the same argument-processing rules as a shell would rather than just splitting on '-'. That's a much larger and more complicated change though.
2018-09-11 01:46:18 +00:00
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
\ . '-Dmacro-with-dash '
\ . '-I''dir with spaces''' . ' -Idir-with-dash'
Fix bug where last c flag was ignored There is currently a check that tries to prevent c-flags that contain '-' in them from being unintentionally split and included in the list of commands. For example, we wouldn't want "-fno-exceptions " to appear as "-fno" and "-exceptions ". The way this check was done was by making sure the last character of the split string was a space. This meant that the very last option to appear in the compile command was ignored (as it doesn't end with a space). This fix explicitly skips the ends-with-space check on the last option in the command-line. This isn't the best fix. Really we should be using the same argument-processing rules as a shell would rather than just splitting on '-'. That's a much larger and more complicated change though.
2018-09-11 01:46:18 +00:00
\ . ' -I'. ale#path#Simplify('kernel/include')
\ )
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
Execute(FlagsFromCompileCommands should tolerate empty values):
AssertEqual '', ale#c#FlagsFromCompileCommands(bufnr(''), '')
Execute(ParseCompileCommandsFlags should tolerate empty values):
bugfix: c.vim: Pull build directory from compilation database The LLVM compiler database JSON already includes a directory where the build was performed: https://clang.llvm.org/docs/JSONCompilationDatabase.html Prefer this directory for fixing relative paths in compiler include arguments in ale#c#ParseCFlags. Without this change, users cannot create a symlink to their compilation database as suggested in the LLVM tooling setup instructions: https://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
2019-01-07 02:17:32 +00:00
AssertEqual '', ale#c#ParseCompileCommandsFlags(bufnr(''), {}, {})
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
Execute(ParseCompileCommandsFlags should parse some basic flags):
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'))
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I ' . ale#path#Simplify('/usr/include/xmms2'),
bugfix: c.vim: Pull build directory from compilation database The LLVM compiler database JSON already includes a directory where the build was performed: https://clang.llvm.org/docs/JSONCompilationDatabase.html Prefer this directory for fixing relative paths in compiler include arguments in ale#c#ParseCFlags. Without this change, users cannot create a symlink to their compilation database as suggested in the LLVM tooling setup instructions: https://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
2019-01-07 02:17:32 +00:00
\ ale#c#ParseCompileCommandsFlags(bufnr(''), { "xmms2-mpris.c": [
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ {
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'directory': ale#path#Simplify('/foo/bar/xmms2-mpris'),
\ 'command': '/usr/bin/cc -I' . ale#path#Simplify('/usr/include/xmms2')
Try to fix the C parsing test on Windows
2018-07-29 18:30:12 +00:00
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' -c ' . ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'),
\ 'file': ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'),
Add support for parsing compile_commands.json files for C compilers
2018-07-29 18:24:19 +00:00
\ },
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
\ ] }, {})
Fix #2195 - Handle the command key being missing
2019-01-27 09:12:59 +00:00
Execute(ParseCompileCommandsFlags should tolerate items without commands):
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'))
Fix #2195 - Handle the command key being missing
2019-01-27 09:12:59 +00:00
AssertEqual
\ '',
\ ale#c#ParseCompileCommandsFlags(bufnr(''), { "xmms2-mpris.c": [
\ {
\ 'directory': '/foo/bar/xmms2-mpris',
\ 'file': '/foo/bar/xmms2-mpris/src/xmms2-mpris.c',
\ },
\ ] }, {})
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
Execute(ParseCompileCommandsFlags should fall back to files in the same directory):
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'))
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I ' . ale#path#Simplify('/usr/include/xmms2'),
bugfix: c.vim: Pull build directory from compilation database The LLVM compiler database JSON already includes a directory where the build was performed: https://clang.llvm.org/docs/JSONCompilationDatabase.html Prefer this directory for fixing relative paths in compiler include arguments in ale#c#ParseCFlags. Without this change, users cannot create a symlink to their compilation database as suggested in the LLVM tooling setup instructions: https://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
2019-01-07 02:17:32 +00:00
\ ale#c#ParseCompileCommandsFlags(bufnr(''), {}, { "src": [
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
\ {
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'directory': ale#path#Simplify('/foo/bar/xmms2-mpris'),
\ 'command': '/usr/bin/cc -I' . ale#path#Simplify('/usr/include/xmms2')
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ . ' -c ' . ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.c'),
\ 'file': ale#path#Simplify((has('win32') ? 'C:' : '') . '/foo/bar/xmms2-mpris/src/xmms2-other.c'),
Improve perf for compile dbs in large projects When using a compilation database (compile_commands.json) in very large projects, significant delays would occur when changing files -- particularly those that happened to be far down the db. Rather than iterating over the whole list every time, we now build up a lookup table based on the tail of the filename (and tail of the directory for widening searches) and iterate over the much smaller list of compile commands for files with the given name. Test metrics (from compile_database_perf/test.sh) show a 90% performance improvement -- from 25 seconds to 2.5 seconds per run.
2018-12-17 04:47:35 +00:00
\ },
\ ] })
Add a test for cflags merging bug
2018-12-29 11:13:23 +00:00
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
Execute(ParseCompileCommandsFlags should take commands from matching .c files for .h files):
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.h'))
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I /usr/include/xmms2',
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
\ ale#c#ParseCompileCommandsFlags(
\ bufnr(''),
\ {
\ 'xmms2-mpris.c': [
\ {
\ 'directory': '/foo/bar/xmms2-mpris',
\ 'file': (has('win32') ? 'C:' : '') . '/foo/bar/xmms2-mpris/src/xmms2-mpris.c',
\ 'command': '/usr/bin/cc -I' . '/usr/include/xmms2'
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
\ . ' -c ' . '/foo/bar/xmms2-mpris/src/xmms2-mpris.c',
\ },
\ ],
\ },
\ {
\ },
\ )
Execute(ParseCompileCommandsFlags should take commands from matching .cpp files for .hpp files):
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.hpp'))
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I /usr/include/xmms2',
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
\ ale#c#ParseCompileCommandsFlags(
\ bufnr(''),
\ {
\ 'xmms2-mpris.cpp': [
\ {
\ 'directory': '/foo/bar/xmms2-mpris',
\ 'file': (has('win32') ? 'C:' : '') . '/foo/bar/xmms2-mpris/src/xmms2-mpris.cpp',
\ 'command': '/usr/bin/cc -I' . '/usr/include/xmms2'
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
\ . ' -c ' . '/foo/bar/xmms2-mpris/src/xmms2-mpris.cpp',
\ },
\ ],
\ },
\ {
\ },
\ )
Execute(ParseCompileCommandsFlags should take commands from matching .cpp files for .h files):
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/xmms2-mpris.h'))
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-I /usr/include/xmms2',
#782 - Use compile commands for matching source files for headers
2019-04-15 20:38:11 +00:00
\ ale#c#ParseCompileCommandsFlags(
\ bufnr(''),
\ {
\ 'xmms2-mpris.cpp': [
\ {
\ 'directory': '/foo/bar/xmms2-mpris',
\ 'file': (has('win32') ? 'C:' : '') . '/foo/bar/xmms2-mpris/src/xmms2-mpris.cpp',
\ 'command': '/usr/bin/cc -I' . '/usr/include/xmms2'
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
\ . ' -c ' . '/foo/bar/xmms2-mpris/src/xmms2-mpris.cpp',
\ },
\ ],
\ },
\ {
\ },
\ )
Execute(ParseCompileCommandsFlags should not take commands from .c files for .h files with different names):
silent noautocmd execute 'file! ' . fnameescape(ale#path#Simplify('/foo/bar/xmms2-mpris/src/other.h'))
AssertEqual
\ '',
\ ale#c#ParseCompileCommandsFlags(
\ bufnr(''),
\ {
\ 'xmms2-mpris.c': [
\ {
\ 'directory': '/foo/bar/xmms2-mpris',
\ 'file': (has('win32') ? 'C:' : '') . '/foo/bar/xmms2-mpris/src/xmms2-mpris.c',
\ 'command': '/usr/bin/cc -I' . '/usr/include/xmms2'
\ . ' -o CMakeFiles/xmms2-mpris.dir/src/xmms2-mpris.c.o'
\ . ' -c ' . '/foo/bar/xmms2-mpris/src/xmms2-mpris.c',
\ },
\ ],
\ },
\ {
\ },
\ )
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
Execute(ParseCFlags should not merge flags):
AssertEqual
\ '-Dgoal=9'
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/subdir'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir with spaces'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/dir-with-dash'))
\ . ' ' . '-I' . ' ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/kernel/include')),
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla -Isubdir '
\ . 'subdir/somedep1.o ' . 'subdir/somedep2.o '
\ . '-I''dir with spaces''' . ' -Idir-with-dash '
\ . 'subdir/somedep3.o ' . 'subdir/somedep4.o '
\ . ' -I'. ale#path#Simplify('kernel/include') . ' '
\ . 'subdir/somedep5.o ' . 'subdir/somedep6.o '
\ )
Cflags: added a test case
2019-01-09 15:39:05 +00:00
Execute(ParseCFlags should handle parenthesis and quotes):
AssertEqual
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ '-Dgoal=9 -Dtest1="('' '')" -Dtest2=''(` `)'' -Dtest3=`(" ")`',
Cflags: added a test case
2019-01-09 15:39:05 +00:00
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
\ 'gcc -Dgoal=9 -Tlinkerfile.ld blabla '
Cflags: added a test case
2019-01-09 15:39:05 +00:00
\ . '-Dtest1="('' '')" file1.o '
\ . '-Dtest2=''(` `)'' file2.o '
\ . '-Dtest3=`(" ")` file3.o '
\ )
Fix cflags parsing (#2510, #2265) (#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
2019-08-17 18:08:14 +00:00
Execute(CFlags we want to pass):
AssertEqual
\ '-I ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/inc'))
\ . ' -I ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/include'))
\ . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/incquote'))
\ . ' -isystem ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/incsystem'))
\ . ' -idirafter ' . ale#Escape(ale#path#Simplify(g:dir. '/test_c_projects/makefile_project/incafter'))
\ . ' -Dmacro=value -D macro2 -Bbdir -B bdir2'
\ . ' -iprefix prefix -iwithprefix prefix2 -iwithprefixbefore prefix3'
\ . ' -isysroot sysroot --sysroot=test --no-sysroot-suffix -imultilib multidir'
\ . ' -Wsome-warning -std=c89 -pedantic -pedantic-errors -ansi'
\ . ' -foption -O2 -C -CC -trigraphs -nostdinc -nostdinc++'
\ . ' -iplugindir=dir -march=native -w',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc'
\ . ' -Iinc -I include -iquote incquote -isystem incsystem -idirafter incafter'
\ . ' -Dmacro=value -D macro2 -Bbdir -B bdir2'
\ . ' -iprefix prefix -iwithprefix prefix2 -iwithprefixbefore prefix3'
\ . ' -isysroot sysroot --sysroot=test --no-sysroot-suffix -imultilib multidir'
\ . ' -Wsome-warning -std=c89 -pedantic -pedantic-errors -ansi'
\ . ' -foption -O2 -C -CC -trigraphs -nostdinc -nostdinc++'
\ . ' -iplugindir=dir -march=native -w'
\ )
Execute(CFlags we dont want to pass):
AssertEqual
\ '',
\ ale#c#ParseCFlags(
\ ale#path#Simplify(g:dir. '/test_c_projects/makefile_project'),
\ 'gcc -Wl,option -Wa,option -Wp,option filename.c somelib.a '
\ . '-fdump-file=name -fdiagnostics-arg -fno-show-column'
\ )
Reference in New Issue Copy Permalink