Commit Graph

574 Commits

Author SHA1 Message Date
swiftlebottomE b224407821 abuild: Use $ABUILD_USERDIR instead of hardcoding path 2022-12-14 22:00:19 +00:00
Natanael Copa e8c1ce6127 abuild: fix cleanoldpkg
we should only delete packages of the specified architecture

fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10078
2022-12-06 16:59:03 +01:00
Natanael Copa ee13f777d5 abuild: fix check of maintainer address
Also disallow leading and trailing spaces/quotes.

fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10080
2022-12-02 16:44:53 +01:00
Rohit Lodha 37e150738e APKBUILD should be $APKBUILD 2022-12-02 07:29:21 +00:00
Natanael Copa 5c542377a8 abuild: fix amove corner cases
fix `amove dir` (without leading or trailing /)

add various testcases for amove
2022-09-23 12:31:56 +02:00
Natanael Copa 04c2c9edde abuild: use grep -E instead of egrep
fixes the warning:

  egrep: warning: egrep is obsolescent; using grep -E
2022-09-12 17:06:21 +02:00
ptrcnull 7878630e26 abuild: add $conflicts to spellchecking 2022-08-29 08:10:37 +00:00
Drew DeVault 1571e2887e Downgrade suid w/o PIE from error to warning
Some languages (such as Hare) do not support position-independent
executables. Such cases require extra care and scrutiny, but should not
be entirely disallowed.
2022-08-28 18:18:49 +02:00
xdavidwu 3ee93ea8bc abuild: print failed patches to stderr 2022-08-05 14:32:26 +00:00
psykose 927f14f6b3
abuild: fix package size for script-only packages 2022-08-05 16:00:36 +02:00
ptrcnull 33ce0536ef
abuild: set GIT_CEILING_DIRECTORIES before running prepare/build/check/package 2022-06-22 17:50:38 +02:00
Natanael Copa e25a2b6fc5 abuild: use timestamp of APKBUILD if not in git
we normally use the last git commit timestamp for creating reproducible
builds. Fall back to APKBUILD timestamp if there are no git commits.
2022-06-22 16:13:07 +02:00
Natanael Copa a845a0bf1d abuild: echo invalid filenames to stderr 2022-06-22 16:13:07 +02:00
Natanael Copa 1a4e76dd74 abuild: export $git to fix fatal: not a git repository
We re-spawn abuild and need to pass $git
2022-06-22 16:13:07 +02:00
Natanael Copa 63467b1ef3 abuild: pass -v option to subshells
Help debugging in fakeroot by passing -v option
2022-06-22 16:13:07 +02:00
Natanael Copa f69cbe8b96 abuild: show usage on stderr on invalid options 2022-06-22 16:13:07 +02:00
Nathan Rennie-Waldock 83f19b7fd8 abuild: Fix always reporting ccache as missing when USE_CCACHE=1 2022-06-14 12:40:59 +00:00
Olliver Schinagl f5d6e5e34b abuild: Do not store whitespaces in license field
Currently, abuild stores the license variable ad-verbatim in the PKGINFO
file. This causes many downstream systems to fail. For example, `apk
info` won't show anything after the newline, our webview that lists
licenses do not show these either.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
2022-06-14 12:08:01 +00:00
donoban d9f03b387a rootbld: add '--cache-dir' when preparing the $BUILD_ROOT
Otherwise apk will rely on defaults 'etc/apk/cache' and 'var/apk/cache'
based on new chroot directory and will delete everything when rootbld finishes.
2022-04-05 08:02:48 +00:00
donoban 84d7b7693d rootbld: run mkusers inside the chroot and don't affect host users 2022-04-05 08:02:48 +00:00
Natanael Copa 9a96275d87 abuild: test that subpkg's dependencies versions are valid
Also verify the version of provides

Fixes: https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10058
2022-01-17 16:14:58 +01:00
Natanael Copa 8824e43ad9 abuild: verify subpkgnames
Refactor pkgname check and also check subpkgnames

Add tests for invalid subpkgnames
2022-01-17 15:44:10 +01:00
Ross Younger d0ccbb7c09 abuild: filter out security.selinux xattrs
This patch modifies abuild's behaviour to be independent of
whether SELinux labels are present in the build environment.

This is a workaround for containerised build environments where the
hosting environment has SELinux enabled. Security labels leak into the
container, manifesting as xattrs.

Discussion thread:
https://lists.alpinelinux.org/~alpine/devel/%3CCA%2Bgy4ieuXLuQddxmPuiucyZbut%3D14cR8tgmGrh0qE9qLDBivmg%40mail.gmail.com%3E
2021-10-11 20:43:40 +02:00
Alex Xu (Hello71) 3ad93d9a83 abuild: default_dbg: various fixes
- fix symlinks
- fix hard links
- fix dbg not first
- fix scan race condition
- fix (non-extended) attrs
- general refactoring
2021-10-11 15:33:01 +00:00
Ariadne Conill 02652f5dd6 abuild: version cmd: providers
The default provider priority is 0, which disables the normal way apk
selects an unversioned virtual dependency.  Instead, version the
provider so that cmd: dependencies can be robustly used like normal
dependencies.
2021-10-11 15:27:28 +00:00
Alex D. ba127ff45c abuild: use sourced filename instead of whole line for initd checks 2021-10-11 14:46:43 +00:00
Natanael Copa 1c00caaddb abuild: make sure to not get colors in git_last_commit
git log may return color codes if users colored output forcibly enabled
with:

[color]
	ui = always

Use `git rev-list` instead of `git log` to make sure that we don't get
any color codes.

fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10042
2021-10-07 13:06:06 +02:00
Samanta Navarro dc99ce423a abuild: fix typos
Typos found with codespell
2021-09-21 09:15:34 +00:00
Kaarle Ritvanen 91c4bc018d rootbld: foreign arch build with QEMU user mode 2021-06-10 14:40:55 +00:00
Leo 74b32d03db fix(abuild): use -print0 **after** the print commands 2021-06-10 14:28:44 +00:00
Leo ac3ee42458 feat(abuild): add support for pyX.Y providers
Now all python packages that install python modules under
/usr/lib/pythonX.Y/site-packages will have a provider that indicates
their MAJOR (X) and MINOR (Y) versions.

pyX maps to the MAJOR version of the package, its objective is to allow
users to quickly install a python module without having to search around
for the correct package, doing `apk add py3.9:foo` will install whatever
packages provides the foo module.

The directories checked only go one level deep, so
'/usr/lib/python3.9/site-packages/date' will generate
py3:date=$pkgver-r$pkgrel.

files ending with .py also count and are added with their .py prefix
stripped away. so '/usr/lib/python3.9/site-packages/six.py' will
generate py3:six=$pkgver-r$pkgrel.

The reason for doing this is the same as creating pc:, so: and cmd:, it
is more reliable and robust to depened on what we known of what the package
provides than to try to guess via the pkgname.

Co-authored-by: Chloe Kudryavtsev <toast@toast.cafe>
2021-05-06 10:50:42 -03:00
Wolf 29557a4a54 Set non-zero size if there are any files in the package
If there are only empty files in the pkgdir, on some filesystems
(discovered on btrfs), du might return 0 for the sum size of the files.
But apk-tools considers packages with size = 0 to be virtual and skips
extraction of any files contained.

To work around that (until it is resolved in apk-tools 3), settings the
size to 1 when it is zero AND some files are present should work fine.
2021-05-06 13:32:08 +00:00
Natanael Copa fd91001089 abuild: allow set extra options for apk index
Use ABUILD_APK_INDEX_OPTS as extra options for apk index. This is so we
can set the apk keys dir to the directory with our temporary test keys
2021-04-29 12:37:38 +02:00
Natanael Copa d7150a3fb1 abuild: warn if -dbg is not first in subpackages
fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10002
2021-04-29 11:45:59 +02:00
Natanael Copa db1950c5ce abuild: test for duplicates when doing checksum
fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10013
2021-04-28 13:02:28 +02:00
Natanael Copa 32b7789e9a abuild: allow override setfattr
In osme situations it might be needed to disable setfattr. Allow this
via: `SETFATTR=true abuild ...`

fixes https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10027
2021-04-28 10:33:23 +02:00
Wolf f523aabce3 Add new lines around the checksums in APKBUILD
In order to make diffs more tidy and the APKBUILD overall more visually
pleasing, new lines are added after opening and before closing quote,
turning

sha512sums="HASH  foo
HASH  bar"

into

sha512sums="
HASH  foo
HASH  bar
"

therefore keeping alignment of file names.
2021-04-12 15:03:02 +00:00
Natanael Copa f35f2aa859 abuild: add test for invalid filenames
reject filenames with newlines

fixes #10024
2021-02-04 14:44:16 +01:00
Drew DeVault b0af30c5be abuild.in: update autoconf test for riscv64 2021-01-04 20:28:09 +01:00
Sören Tempel 3665a7a994 abuild rootbld: disable real chown calls in fakeroot
By default, fakeroot forwards chown system calls to the libc and ignores
EPERM errors. Unfortunately, when fakeroot is used inside a restricted
bubblewrap environment, bubblewrap intercepts these system calls and
returns EINVAL. The EINVAL return value is not masked by fakeroot and
returned to the caller, thereby causing failures of mv(1), install(1),
chown(1), … which use the chown system calls internally.

Setting the FAKEROOTDONTTRYCHOWN environment variable prevents the chown
systemcalls to be performed in the first place. This variable is only
set in the environment created through bubblewrap by abuild rootbld.

Fixes #10021
2020-12-21 22:00:19 +01:00
Leo c59629326b abuild.in: check for a valid pkgrel with apk version --check
fixes #10011
2020-12-13 11:23:42 -03:00
Natanael Copa 10aa67a0ca Revert "set CARGO_HOME to $SRCDEST/cargo"
the SRCDEST may be shared by multiple builders and apparently cargo does
not seem to handle that well. There are also no good way to do clean-up
of the cache for purging things that is no longer in use.

This reverts commit af0c88e6ab.
2020-11-27 15:17:11 +00:00
Natanael Copa 32785f6360 abuild: restore working dir after updating index
This fixes issue with `abuild cleanpkg all`, which would fail to set
SOURCE_DATE_EPOC for reproducible builds.
2020-10-29 14:46:46 +00:00
Leo 4c38544a96 abuild: don't warn about static libraries in -dev 2020-10-29 11:38:38 +00:00
Leo 8eeca0adad *: say we are using GPL-2.0-only 2020-10-23 11:39:18 -03:00
Leo ba3e575d37 abuild: accept lib64 as an option to ignore /lib64 checks
this is required when we package stuff with compatibility to glibc like
libc6-compat
2020-07-20 14:03:52 -03:00
Natanael Copa dd4cd9d606 abuild: return error if there are more than one maintainer
fixes #5421
2020-07-08 13:15:13 +02:00
Natanael Copa ff11a9a0a8 abuild: provide a list of patches that failed
Try all patches and return of list of patches that failed rather than
exit on first failed patch.
2020-07-06 10:59:56 +00:00
Leo 29a3433b43 abuild: don't error out immediately in postcheck()
Store exit code in the variable 'e', then return it, if there are no
errors then it will return 0 as that is the default value, otherwise it
will return 1 and error out as previously
2020-07-06 10:46:26 +00:00
Leo cd004c0232 error out if /lib64 or /usr/lib64 is found 2020-07-06 10:46:26 +00:00