RepoMirrors
/
abuild
mirror of https://gitlab.alpinelinux.org/alpine/abuild.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

abuild-tar: drop legacy checksum mechanism 

This mechanism was an optional speed optimization for apk-tools which has
been replaced with a better one **before the 2.0 full release** of apk-tools.

This in combination with the fact that the code is endian dependant and
therefor is incompatible with reproducible builds seems enough reason to
remove the code.
This commit is contained in:
Sertonix 2024-09-10 21:23:19 +02:00 committed by Natanael Copa
parent a7e7587758
commit c1c233a45a
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
abuild-tar.c
View File

@ -271,22 +271,6 @@ static int buf_add_ext_header_hexdump(struct buf *b, const char *hdr, const unsi
return 0; return 0;
} }
static void add_legacy_checksum(struct tar_header *hdr, const EVP_MD *md, const unsigned char *digest)
{
struct {
char id[4];
uint16_t nid;
uint16_t size;
} mdinfo;
memcpy(mdinfo.id, "APK2", 4);
mdinfo.nid = EVP_MD_nid(md);
mdinfo.size = EVP_MD_size(md);
memcpy(&hdr->linkname[3], &mdinfo, sizeof(mdinfo));
memcpy(&hdr->linkname[3+sizeof(mdinfo)], digest, mdinfo.size);
tarhdr_checksum(hdr);
}
static int do_it(const EVP_MD *md, int cut) static int do_it(const EVP_MD *md, int cut)
{ {
char checksumhdr[32]; char checksumhdr[32];
@ -323,7 +307,6 @@ static int do_it(const EVP_MD *md, int cut)
if (hdr.typeflag != '2') { if (hdr.typeflag != '2') {
EVP_Digest(data.ptr, size, digest, NULL, md, NULL); EVP_Digest(data.ptr, size, digest, NULL, md, NULL);
add_legacy_checksum(&hdr, md, digest);
} else { } else {
name_len = strnlen(hdr.linkname, sizeof(hdr.linkname)); name_len = strnlen(hdr.linkname, sizeof(hdr.linkname));
EVP_Digest(hdr.linkname, name_len, digest, NULL, md, NULL); EVP_Digest(hdr.linkname, name_len, digest, NULL, md, NULL);