RepoMirrors/abuild
1
0
Fork 0
mirror of https://gitlab.alpinelinux.org/alpine/abuild.git synced 2024-12-21 22:50:03 +00:00
Code Issues Projects Releases Wiki Activity

abuild: warn if pycache is found

Browse Source 
and add tests for -pyc package split
This commit is contained in:
Natanael Copa 2023-04-18 11:56:37 +02:00
parent dd07911cbf
commit b24bc33446
2 changed files with 66 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
abuild.in
View File

@ -824,6 +824,14 @@ postcheck() {
e=1
fi
fi
# look for pycache
# wildcard should always get the system python dir, and this is faster than
# trying to calculate the python version.
local pycache="$(find "$dir"/usr/lib/python* \( -type d -a -name "__pycache__" \))"
if [ -n "$pycache" ] && [ "${name%-pyc}" = "$name" ]; then
warning "Found __pycache__ but package name doesn't end with -pyc"
fi
# check that we don't have any files names with newline
i=$(find "$dir" -name $'*\n*')
if [ -n "$i" ]; then

59
tests/abuild_test
View File

@ -35,7 +35,9 @@ init_tests \
abuild_devhelp \
abuild_check_maintainer \
abuild_cleanoldpkg \
abuild_path_with_spaces
abuild_path_with_spaces \
abuild_pyc_warn \
abuild_pyc
export ABUILD_SHAREDIR=$(atf_get_srcdir)/..
export ABUILD_CONF=/dev/null
@ -845,3 +847,58 @@ abuild_path_with_spaces_body() {
-e match:"Build complete" \
abuild
}
abuild_pyc_warn_body() {
init_keys
mkdir -p pycachetest
cd pycachetest
cat >APKBUILD <<-EOF
# Maintainer: Joe User <juser@example.com>
pkgname="pycachetest"
pkgver="1.0"
pkgrel=0
pkgdesc="Dummy test package"
url="https://gitlab.alpinelinux.org/alpine/aports"
arch="noarch"
license="MIT"
source=""
package() {
mkdir -p "\$pkgdir"/usr/lib/python3.11/site-packages/test/__pycache__/
touch "\$pkgdir"/usr/lib/python3.11/site-packages/test/__pycache__/main.cpython-311.pyc
}
EOF
atf_check -e match:"WARNING.*pyc*" abuild rootpkg
}
abuild_pyc_body() {
init_keys
mkdir -p foo
cd foo
cat >APKBUILD <<-EOF
# Maintainer: Joe User <juser@example.com>
pkgname="foo"
pkgver="1.0"
pkgrel=0
pkgdesc="Dummy test package"
url="https://gitlab.alpinelinux.org/alpine/aports"
arch="noarch"
license="MIT"
source=""
subpackages="\$pkgname-pyc"
package() {
mkdir -p "\$pkgdir"/usr/lib/python3.11/site-packages/test/__pycache__/
touch "\$pkgdir"/usr/lib/python3.11/site-packages/test/__pycache__/main.cpython-311.pyc
}
EOF
atf_check -o match:"->" -e not-match:"WARNING.*pyc*" abuild rootpkg
atf_check -o match:"__pycache__" find pkg/foo-pyc -name '__pycache__'
# verify install_if is correct
atf_check -o match:"foo=1.0-r0" -o match:"pyc" \
grep install_if pkg/.control.foo-pyc/.PKGINFO
}