RepoMirrors
/
abuild
mirror of https://gitlab.alpinelinux.org/alpine/abuild.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

abuild-sudo: prevent forging of user name

This commit is contained in:
Kaarle Ritvanen 2017-07-17 21:02:35 +03:00
parent 443fc07c79
commit 829a501de7
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
abuild-sudo.c
View File

@ -77,22 +77,19 @@ int main(int argc, const char *argv[])
if (grent == NULL)
errx(1, "%s: Group not found", ABUILD_GROUP);
char *name = getlogin();
if (name == NULL) {
pw = getpwuid(getuid());
if (pw)
name = pw->pw_name;
}
char *name = NULL;
pw = getpwuid(getuid());
if (pw)
name = pw->pw_name;
if (!is_in_group(grent->gr_gid)) {
errx(1, "User %s is not a member of group %s\n",
name ? name : "(unknown)", ABUILD_GROUP);
}
if (name) {
setenv("USER", name, 1);
} else {
if (name == NULL)
warnx("Could not find username for uid %d\n", getuid());
}
setenv("USER", name ?: "", 1);
cmd = strrchr(argv[0], '/');
if (cmd)