suckless
/
sbase
mirror of git://git.suckless.org/sbase
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
1,262 Commits 2 Branches 0 Tags 3.2 MiB
Commit Graph

18 Commits

Author SHA1 Message Date
FRIGN 286df29e7d Make already audited tools argv-centric instead of argc-centric 
This has already been suggested by Evan Gates <evan.gates@gmail.com>
and he's totally right about it.
So, what's the problem?
I wrote a testing program asshole.c with

int
main(void)
{
        execl("/path/to/sbase/echo", "echo", "test");
        return 0;
}

and checked the results with glibc and musl. Note that the
sentinel NULL is missing from the end of the argument list.
glibc calculates an argc of 5, musl 4 (instead of 2) and thus
mess up things anyway.
The powerful arg.h also focuses on argv instead of argc as well,
but ignoring argc completely is also the wrong way to go.
Instead, a more idiomatic approach is to check *argv only and
decrement argc on the go.
While at it, I rewrote yes(1) in an argv-centric way as well.

All audited tools have been "fixed" and each following audited
tool will receive the same treatment.
 2015-03-02 14:19:26 +01:00
FRIGN 0226c05105 Audit printenv(1) 
1) argc style
2) safeguard argv-loop as already seen in echo(1) with argc-decrement.
 2015-02-28 21:47:17 +01:00
FRIGN 31572c8b0e Clean up #includes 2015-02-14 21:12:23 +01:00
FRIGN 22c6502b67 Add mandoc-manpage for echo(1) 
and mark it as finished in the README.
 2015-01-23 23:49:24 +01:00
FRIGN ec8246bbc6 Un-boolify sbase 
It actually makes the binaries smaller, the code easier to read
(gems like "val == true", "val == false" are gone) and actually
predictable in the sense of that we actually know what we're
working with (one bitwise operator was quite adventurous and
should now be fixed).

This is also more consistent with the other suckless projects
around which don't use boolean types.
 2014-11-14 10:54:20 +00:00
FRIGN eee98ed3a4 Fix coding style 
It was about damn time. Consistency is very important in such a
big codebase.
 2014-11-13 18:08:43 +00:00
sin 0c5b7b9155 Stop using EXIT_{SUCCESS,FAILURE} 2014-10-02 23:46:59 +01:00
sin df1b25a187 No need to include unistd.h in echo(1) 2014-06-25 21:27:53 +01:00
Hiltjo Posthuma 953ebf3573 code style 
Signed-off-by: Hiltjo Posthuma <hiltjo@codemadness.org>
 2014-06-01 18:02:30 +01:00
sin b5a511dacf Exit with EXIT_SUCCESS/EXIT_FAILURE instead of 0 and 1 
Fixed for consistency purposes.
 2013-10-07 16:44:22 +01:00
stateless 7216a53a7e Remove unnecessary exit(1) in usage() 
Signed-off-by: Christoph Lohmann <20h@r-36.net>
 2013-06-19 19:58:19 +02:00
Christoph Lohmann 4d38f60685 Eliminating the getopt disgrace. 2013-06-14 20:20:47 +02:00
Connor Lane Smith 5156758e21 kill -l 2011-06-10 02:56:13 +01:00
Connor Lane Smith 6ef3d9174b add ls; simpler pwd 2011-05-26 04:01:20 +01:00
Connor Lane Smith f458397d5a no, getopt.h is gnu specific 2011-05-24 18:58:36 +01:00
pancake da547fb294 add missing #include <getopt.h> 
do not override CC in config.mk
 2011-05-24 14:34:26 +02:00
Connor Lane Smith 9714d7b1d3 getopt 2011-05-24 01:13:34 +01:00
Connor Lane Smith 8e26716a5a initial commit 2011-05-23 02:36:34 +01:00