From 7b8d7fb78edc79a99f0c2a67b5a8ca725ec56424 Mon Sep 17 00:00:00 2001 From: sin Date: Sun, 16 Nov 2014 14:43:10 +0000 Subject: [PATCH] Fix uninitialized use of ret in expr(1) --- expr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/expr.c b/expr.c index 49fa040..3e0cd8e 100644 --- a/expr.c +++ b/expr.c @@ -117,10 +117,11 @@ match(Val vstr, Val vregx) if (re.re_nsub) { len = matches[1].rm_eo - matches[1].rm_so + 1; - ret = emalloc(len); /* TODO: free ret */ - d = strtoimax(ret, &p, 10); + ret = malloc(len); /* TODO: free ret */ + if (!ret) + enprintf(3, "malloc:"); strlcpy(ret, str + matches[1].rm_so, len); - + d = strtoimax(ret, &p, 10); if (*ret && !*p) return (Val){ NULL, d }; return (Val){ ret, 0 };