From 0d6d1dc02f6ade56a60337b77d279468d24ba69b Mon Sep 17 00:00:00 2001 From: FRIGN Date: Tue, 29 Sep 2015 23:14:59 +0200 Subject: [PATCH] Check explicit length in od(1) If you pass an empty string, the null-char will always match with strchr()! --- od.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/od.c b/od.c index b24a279..407f550 100644 --- a/od.c +++ b/od.c @@ -108,13 +108,13 @@ main(int argc, char *argv[]) ARGBEGIN { case 'A': s = EARGF(usage()); - if (strlen(s) > 1 || !strchr("doxn", s[0])) + if (strlen(s) != 1 || !strchr("doxn", s[0])) usage(); radix = s[0]; break; case 't': s = EARGF(usage()); - if (strlen(s) > 1 || !strchr("acdoux", s[0])) + if (strlen(s) != 1 || !strchr("acdoux", s[0])) usage(); type = s[0]; break;