RepoMirrors
/
tdesktop
mirror of https://github.com/telegramdesktop/tdesktop
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed crash when deleting message from non-user.

This commit is contained in:
23rd 2024-04-27 16:39:13 +03:00
parent e81465a54e
commit e0db0642bd
1 changed files with 28 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
Telegram/SourceFiles/boxes/moderate_messages_box.cpp
View File

@ -43,36 +43,43 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
namespace { namespace {
enum class ModerateOption { using Users = std::vector<not_null<UserData*>>;
Ban = (1 << 0),
DeleteAll = (1 << 1), struct ModerateOptions final {
bool allCanBan = false;
bool allCanDelete = false;
Users users;
}; };
inline constexpr bool is_flag_type(ModerateOption) { return true; }
using ModerateOptions = base::flags<ModerateOption>;
ModerateOptions CalculateModerateOptions(const HistoryItemsList &items) { ModerateOptions CalculateModerateOptions(const HistoryItemsList &items) {
Expects(!items.empty()); Expects(!items.empty());
auto result = ModerateOptions{
.allCanBan = true,
.allCanDelete = true,
};
const auto peer = items.front()->history()->peer; const auto peer = items.front()->history()->peer;
auto allCanBan = true;
auto allCanDelete = true;
for (const auto &item : items) { for (const auto &item : items) {
if (!allCanBan && !allCanDelete) { if (!result.allCanBan && !result.allCanDelete) {
return ModerateOptions(0); return {};
} }
if (peer != item->history()->peer) { if (peer != item->history()->peer) {
return ModerateOptions(0); return {};
} }
if (!item->suggestBanReport()) { if (!item->suggestBanReport()) {
allCanBan = false; result.allCanBan = false;
} }
if (!item->suggestDeleteAllReport()) { if (!item->suggestDeleteAllReport()) {
allCanDelete = false; result.allCanDelete = false;
}
if (const auto user = item->from()->asUser()) {
if (!ranges::contains(result.users, not_null{ user })) {
result.users.push_back(user);
} }
} }
return ModerateOptions(0) }
| (allCanBan ? ModerateOption::Ban : ModerateOptions(0)) return result;
| (allCanDelete ? ModerateOption::DeleteAll : ModerateOptions(0));
} }
class Button final : public Ui::RippleButton { class Button final : public Ui::RippleButton {
@ -180,27 +187,16 @@ void CreateModerateMessagesBox(
not_null<Ui::GenericBox*> box, not_null<Ui::GenericBox*> box,
const HistoryItemsList &items, const HistoryItemsList &items,
Fn<void()> confirmed) { Fn<void()> confirmed) {
using Users = std::vector<not_null<UserData*>>;
struct Controller final { struct Controller final {
rpl::event_stream<bool> toggleRequestsFromTop; rpl::event_stream<bool> toggleRequestsFromTop;
rpl::event_stream<bool> toggleRequestsFromInner; rpl::event_stream<bool> toggleRequestsFromInner;
rpl::event_stream<bool> checkAllRequests; rpl::event_stream<bool> checkAllRequests;
Fn<Users()> collectRequests; Fn<Users()> collectRequests;
}; };
const auto options = CalculateModerateOptions(items); const auto [allCanBan, allCanDelete, users] = CalculateModerateOptions(
items);
const auto inner = box->verticalLayout(); const auto inner = box->verticalLayout();
const auto users = [&] {
auto result = Users();
for (const auto &item : items) {
if (const auto user = item->from()->asUser()) {
if (!ranges::contains(result, not_null{ user })) {
result.push_back(user);
}
}
}
return result;
}();
Assert(!users.empty()); Assert(!users.empty());
const auto confirms = inner->lifetime().make_state<rpl::event_stream<>>(); const auto confirms = inner->lifetime().make_state<rpl::event_stream<>>();
@ -460,7 +456,7 @@ void CreateModerateMessagesBox(
}); });
} }
if (options & ModerateOption::DeleteAll) { if (allCanDelete) {
Ui::AddSkip(inner); Ui::AddSkip(inner);
Ui::AddSkip(inner); Ui::AddSkip(inner);
@ -490,7 +486,7 @@ void CreateModerateMessagesBox(
u->session().api().deleteAllFromParticipant(c, u); u->session().api().deleteAllFromParticipant(c, u);
}); });
} }
if (options & ModerateOption::Ban) { if (allCanBan) {
auto ownedWrap = object_ptr<Ui::SlideWrap<Ui::VerticalLayout>>( auto ownedWrap = object_ptr<Ui::SlideWrap<Ui::VerticalLayout>>(
inner, inner,
object_ptr<Ui::VerticalLayout>(inner)); object_ptr<Ui::VerticalLayout>(inner));
@ -680,6 +676,6 @@ void CreateModerateMessagesBox(
bool CanCreateModerateMessagesBox(const HistoryItemsList &items) { bool CanCreateModerateMessagesBox(const HistoryItemsList &items) {
const auto options = CalculateModerateOptions(items); const auto options = CalculateModerateOptions(items);
return (options & ModerateOption::Ban) return (options.allCanBan || options.allCanDelete)
|| (options & ModerateOption::DeleteAll); && !options.users.empty();
} }