From 96062039c75dddaeb4bf92431fa6ec4aa7866f6f Mon Sep 17 00:00:00 2001 From: John Preston Date: Tue, 9 May 2017 22:33:50 +0300 Subject: [PATCH] Improve RateCallBox design. --- Telegram/SourceFiles/boxes/rate_call_box.cpp | 16 +++++++++------- Telegram/SourceFiles/boxes/rate_call_box.h | 1 - Telegram/SourceFiles/calls/calls.style | 7 +++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Telegram/SourceFiles/boxes/rate_call_box.cpp b/Telegram/SourceFiles/boxes/rate_call_box.cpp index ac3021cc07..a09fdd70c8 100644 --- a/Telegram/SourceFiles/boxes/rate_call_box.cpp +++ b/Telegram/SourceFiles/boxes/rate_call_box.cpp @@ -38,11 +38,13 @@ constexpr auto kMaxRating = 5; RateCallBox::RateCallBox(QWidget*, uint64 callId, uint64 callAccessHash) : _callId(callId) -, _callAccessHash(callAccessHash) -, _label(this, lang(lng_call_rate_label), Ui::FlatLabel::InitType::Simple, st::boxLabel) { +, _callAccessHash(callAccessHash) { } void RateCallBox::prepare() { + auto titleWidth = st::boxWideWidth - 2 * st::boxTitlePosition.x(); + auto titleText = st::boxTitleFont->elided(lang(lng_call_rate_label), titleWidth); + setTitle(titleText); addButton(lang(lng_cancel), [this] { closeBox(); }); for (auto i = 0; i < kMaxRating; ++i) { @@ -57,9 +59,9 @@ void RateCallBox::prepare() { void RateCallBox::resizeEvent(QResizeEvent *e) { BoxContent::resizeEvent(e); - _label->moveToLeft(st::callRatingPadding.left(), st::callRatingPadding.top()); - auto starLeft = st::callRatingPadding.left() + st::callRatingStarLeft; - auto starTop = _label->bottomNoMargins() + st::callRatingStarTop; + auto starsWidth = (_stars.size() * st::callRatingStar.width); + auto starLeft = (width() - starsWidth) / 2; + auto starTop = st::callRatingStarTop; for (auto &star : _stars) { star->moveToLeft(starLeft, starTop); starLeft += star->width(); @@ -128,9 +130,9 @@ void RateCallBox::onSend() { } void RateCallBox::updateMaxHeight() { - auto newHeight = st::callRatingPadding.top() + _label->heightNoMargins() + st::callRatingStarTop + _stars.back()->heightNoMargins() + st::callRatingPadding.bottom(); + auto newHeight = st::callRatingPadding.top() + st::callRatingStarTop + _stars.back()->heightNoMargins() + st::callRatingPadding.bottom(); if (_comment) { newHeight += st::callRatingCommentTop + _comment->height(); } - setDimensions(st::boxWidth, newHeight); + setDimensions(st::boxWideWidth, newHeight); } diff --git a/Telegram/SourceFiles/boxes/rate_call_box.h b/Telegram/SourceFiles/boxes/rate_call_box.h index 679ae044d3..a4270828ee 100644 --- a/Telegram/SourceFiles/boxes/rate_call_box.h +++ b/Telegram/SourceFiles/boxes/rate_call_box.h @@ -56,7 +56,6 @@ private: uint64 _callAccessHash = 0; int _rating = 0; - object_ptr _label; std::vector> _stars; object_ptr _comment = { nullptr }; diff --git a/Telegram/SourceFiles/calls/calls.style b/Telegram/SourceFiles/calls/calls.style index 7488f41743..e4f6686023 100644 --- a/Telegram/SourceFiles/calls/calls.style +++ b/Telegram/SourceFiles/calls/calls.style @@ -167,7 +167,7 @@ callReDial: IconButton { rippleAreaSize: 40px; } -callRatingPadding: margins(24px, 26px, 24px, 8px); +callRatingPadding: margins(24px, 26px, 24px, 0px); callRatingStar: IconButton { width: 36px; height: 36px; @@ -182,13 +182,12 @@ callRatingStar: IconButton { rippleAreaSize: 36px; } callRatingStarFilled: icon {{ "call_rating_filled", lightButtonFg }}; -callRatingStarLeft: -7px; -callRatingStarTop: 6px; +callRatingStarTop: 4px; callRatingComment: InputField(defaultInputField) { textMargins: margins(1px, 26px, 1px, 4px); heightMax: 135px; } -callRatingCommentTop: 2px; +callRatingCommentTop: 8px; callDebugLabel: FlatLabel(defaultFlatLabel) { margin: margins(24px, 0px, 24px, 0px);