mirror of
https://github.com/prometheus-community/postgres_exporter
synced 2025-05-16 23:08:45 +00:00
Merge pull request #734 from kjbass/master
Close DB connection after probe completes.
This commit is contained in:
commit
94a89b0166
@ -104,6 +104,9 @@ func handleProbe(logger log.Logger) http.HandlerFunc {
|
||||
return
|
||||
}
|
||||
|
||||
// Cleanup underlying connections to prevent connection leaks
|
||||
defer pc.Close()
|
||||
|
||||
// TODO(@sysadmind): Remove the registry.MustRegister() call below and instead handle the collection here. That will allow
|
||||
// for the passing of context, handling of timeouts, and more control over the collection.
|
||||
// The current NewProbeCollector() implementation relies on the MustNewConstMetric() call to create the metrics which is not
|
||||
|
@ -83,3 +83,7 @@ func (pc *ProbeCollector) Collect(ch chan<- prometheus.Metric) {
|
||||
}
|
||||
wg.Wait()
|
||||
}
|
||||
|
||||
func (pc *ProbeCollector) Close() error {
|
||||
return pc.db.Close()
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user