RepoMirrors/postgres_exporter
1
0
Fork 0
mirror of https://github.com/prometheus-community/postgres_exporter synced 2025-04-04 23:29:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #771 from khkhalifa/master

Browse Source 
Fix pg_setting different help values
This commit is contained in:
Joe Adams 2023-04-23 18:35:33 -04:00 committed by GitHub
commit 8b661c9c3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/postgres_exporter/pg_setting.go
View File

@ -70,7 +70,7 @@ func (s *pgSetting) metric(labels prometheus.Labels) prometheus.Metric {
err error err error
name = strings.Replace(s.name, ".", "_", -1) name = strings.Replace(s.name, ".", "_", -1)
unit = s.unit // nolint: ineffassign unit = s.unit // nolint: ineffassign
shortDesc = s.shortDesc shortDesc = fmt.Sprintf("Server Parameter: %s", s.name)
subsystem = "settings" subsystem = "settings"
val float64 val float64
) )

22
cmd/postgres_exporter/pg_setting_test.go
View File

@ -40,7 +40,7 @@ var fixtures = []fixture{
unit: "seconds", unit: "seconds",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_seconds_fixture_metric_seconds", help: "Foo foo foo [Units converted to seconds.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_seconds_fixture_metric_seconds", help: "Server Parameter: seconds_fixture_metric [Units converted to seconds.]", constLabels: {}, variableLabels: []}`,
v: 5, v: 5,
}, },
{ {
@ -56,7 +56,7 @@ var fixtures = []fixture{
unit: "seconds", unit: "seconds",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_milliseconds_fixture_metric_seconds", help: "Foo foo foo [Units converted to seconds.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_milliseconds_fixture_metric_seconds", help: "Server Parameter: milliseconds_fixture_metric [Units converted to seconds.]", constLabels: {}, variableLabels: []}`,
v: 5, v: 5,
}, },
{ {
@ -72,7 +72,7 @@ var fixtures = []fixture{
unit: "bytes", unit: "bytes",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_eight_kb_fixture_metric_bytes", help: "Foo foo foo [Units converted to bytes.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_eight_kb_fixture_metric_bytes", help: "Server Parameter: eight_kb_fixture_metric [Units converted to bytes.]", constLabels: {}, variableLabels: []}`,
v: 139264, v: 139264,
}, },
{ {
@ -88,7 +88,7 @@ var fixtures = []fixture{
unit: "bytes", unit: "bytes",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_16_kb_real_fixture_metric_bytes", help: "Foo foo foo [Units converted to bytes.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_16_kb_real_fixture_metric_bytes", help: "Server Parameter: 16_kb_real_fixture_metric [Units converted to bytes.]", constLabels: {}, variableLabels: []}`,
v: 49152, v: 49152,
}, },
{ {
@ -104,7 +104,7 @@ var fixtures = []fixture{
unit: "bytes", unit: "bytes",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_16_mb_real_fixture_metric_bytes", help: "Foo foo foo [Units converted to bytes.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_16_mb_real_fixture_metric_bytes", help: "Server Parameter: 16_mb_real_fixture_metric [Units converted to bytes.]", constLabels: {}, variableLabels: []}`,
v: 5.0331648e+07, v: 5.0331648e+07,
}, },
{ {
@ -120,7 +120,7 @@ var fixtures = []fixture{
unit: "bytes", unit: "bytes",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_32_mb_real_fixture_metric_bytes", help: "Foo foo foo [Units converted to bytes.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_32_mb_real_fixture_metric_bytes", help: "Server Parameter: 32_mb_real_fixture_metric [Units converted to bytes.]", constLabels: {}, variableLabels: []}`,
v: 1.00663296e+08, v: 1.00663296e+08,
}, },
{ {
@ -136,7 +136,7 @@ var fixtures = []fixture{
unit: "bytes", unit: "bytes",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_64_mb_real_fixture_metric_bytes", help: "Foo foo foo [Units converted to bytes.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_64_mb_real_fixture_metric_bytes", help: "Server Parameter: 64_mb_real_fixture_metric [Units converted to bytes.]", constLabels: {}, variableLabels: []}`,
v: 2.01326592e+08, v: 2.01326592e+08,
}, },
{ {
@ -152,7 +152,7 @@ var fixtures = []fixture{
unit: "", unit: "",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_bool_on_fixture_metric", help: "Foo foo foo", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_bool_on_fixture_metric", help: "Server Parameter: bool_on_fixture_metric", constLabels: {}, variableLabels: []}`,
v: 1, v: 1,
}, },
{ {
@ -168,7 +168,7 @@ var fixtures = []fixture{
unit: "", unit: "",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_bool_off_fixture_metric", help: "Foo foo foo", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_bool_off_fixture_metric", help: "Server Parameter: bool_off_fixture_metric", constLabels: {}, variableLabels: []}`,
v: 0, v: 0,
}, },
{ {
@ -184,7 +184,7 @@ var fixtures = []fixture{
unit: "seconds", unit: "seconds",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_special_minus_one_value_seconds", help: "foo foo foo [Units converted to seconds.]", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_special_minus_one_value_seconds", help: "Server Parameter: special_minus_one_value [Units converted to seconds.]", constLabels: {}, variableLabels: []}`,
v: -1, v: -1,
}, },
{ {
@ -200,7 +200,7 @@ var fixtures = []fixture{
unit: "", unit: "",
err: "", err: "",
}, },
d: `Desc{fqName: "pg_settings_rds_rds_superuser_reserved_connections", help: "Sets the number of connection slots reserved for rds_superusers.", constLabels: {}, variableLabels: []}`, d: `Desc{fqName: "pg_settings_rds_rds_superuser_reserved_connections", help: "Server Parameter: rds.rds_superuser_reserved_connections", constLabels: {}, variableLabels: []}`,
v: 2, v: 2,
}, },
{ {