RepoMirrors/postgres_exporter
1
0
Fork 0
mirror of https://github.com/prometheus-community/postgres_exporter synced 2025-04-23 23:45:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

URL encode username/password fields

Browse Source 
Fixes #188.
This commit is contained in:
Adam Harrison 2018-05-22 11:19:28 +01:00 committed by Will Rouesnel
parent 9eff17a257
commit 3f905289a2
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/postgres_exporter/postgres_exporter.go
View File

@ -1086,8 +1086,9 @@ func getDataSource() string {
pass = os.Getenv("DATA_SOURCE_PASS") pass = os.Getenv("DATA_SOURCE_PASS")
} }
ui := url.UserPassword(user, pass).String()
uri := os.Getenv("DATA_SOURCE_URI") uri := os.Getenv("DATA_SOURCE_URI")
dsn = "postgresql://" + user + ":" + pass + "@" + uri dsn = "postgresql://" + ui + "@" + uri
} }
return dsn return dsn

2
cmd/postgres_exporter/postgres_exporter_test.go
View File

@ -105,7 +105,7 @@ func (s *FunctionalSuite) TestEnvironmentSettingWithSecretsFiles(c *C) {
c.Assert(err, IsNil) c.Assert(err, IsNil)
defer UnsetEnvironment(c, "DATA_SOURCE_URI") defer UnsetEnvironment(c, "DATA_SOURCE_URI")
var expected = "postgresql://custom_username:custom_password@localhost:5432/?sslmode=disable" var expected = "postgresql://custom_username$&+,%2F%3A;=%3F%40:custom_password$&+,%2F%3A;=%3F%40@localhost:5432/?sslmode=disable"
dsn := getDataSource() dsn := getDataSource()
if dsn != expected { if dsn != expected {

2
cmd/postgres_exporter/tests/username_file
View File

@ -1 +1 @@
custom_username custom_username$&+,/:;=?@

2
cmd/postgres_exporter/tests/userpass_file
View File

@ -1 +1 @@
custom_password custom_password$&+,/:;=?@