RepoMirrors/postgres_exporter
1
0
Fork 0
mirror of https://github.com/prometheus-community/postgres_exporter synced 2025-04-22 15:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Discover only databases that are not templates and allow connections (#297)

Browse Source 
* Discover only databases that are not templates and allow connections

* Update readme
This commit is contained in:
Alexis Sellier 2019-08-12 03:40:58 +02:00 committed by Will Rouesnel
parent c768e64548
commit 1ab8d2bbc8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -163,7 +163,7 @@ flag. This removes all built-in metrics, and uses only metrics defined by querie
### Automatically discover databases ### Automatically discover databases
To scrape metrics from all databases on a database server, the database DSN's can be dynamically discovered via the To scrape metrics from all databases on a database server, the database DSN's can be dynamically discovered via the
`--auto-discover-databases` flag. When true, `SELECT datname FROM pg_database` is run for all configured DSN's. From the `--auto-discover-databases` flag. When true, `SELECT datname FROM pg_database WHERE datallowconn = true AND datistemplate = false` is run for all configured DSN's. From the
result a new set of DSN's is created for which the metrics are scraped. result a new set of DSN's is created for which the metrics are scraped.
In addition, the option `--exclude-databases` adds the possibily to filter the result from the auto discovery to discard databases you do not need. In addition, the option `--exclude-databases` adds the possibily to filter the result from the auto discovery to discard databases you do not need.

2
cmd/postgres_exporter/postgres_exporter.go
View File

@ -1074,7 +1074,7 @@ func newDesc(subsystem, name, help string, labels prometheus.Labels) *prometheus
} }
func queryDatabases(server *Server) ([]string, error) { func queryDatabases(server *Server) ([]string, error) {
rows, err := server.db.Query("SELECT datname FROM pg_database") // nolint: safesql rows, err := server.db.Query("SELECT datname FROM pg_database WHERE datallowconn = true AND datistemplate = false") // nolint: safesql
if err != nil { if err != nil {
return nil, fmt.Errorf("Error retrieving databases: %v", err) return nil, fmt.Errorf("Error retrieving databases: %v", err)
} }