mirror of https://github.com/mpv-player/mpv
c1de4bb745
vo_dmabuf_wayland worked by allocating entries to a pool and then having a lot of complex logic dealing with releasing buffers, pending entries, etc. along with some other not so nice things. Instead, we can rewrite this logic so that the wl_buffers created by the imported dmabuf is instead stored in a linked list, wl_list. We can simply append our buffers to the list when needed and destroy everything at the end. On every frame, we can check the ids of our surfaces and reuse existing buffers, so in practice there will only ever be a handful at a time. Some other small changes were made in an attempt to organize the vaapi/drmprime code a little better as well. An important change is to always enforce at least a minimum number of buffers. Certain formats would not make enough unique buffers, and this results in flickering/artifacts occuring. The old way to attempt to deal with this was to clear out all the existing buffers and remake them, but this gets complicated and also didn't always work. An easy solution to this is just create more buffers which appears to solve this problem. The actual number needed is not really based on anything solid, but 8 is a reasonable number to create for the lifetime of a file and it seems to do the trick. Additionally, seeking/loading new files can result in flicker artificts due to buffers being reused when they shouldn't. When that happens, we flip a bool so all the buffers get destroyed in draw_frame to avoid any visual glitches. |
||
|---|---|---|
| .. | ||
| cocoa | ||
| d3d11 | ||
| gpu | ||
| gpu_next | ||
| hwdec | ||
| mac | ||
| opengl | ||
| placebo | ||
| vulkan | ||
| win32 | ||
| wldmabuf | ||
| android_common.c | ||
| android_common.h | ||
| aspect.c | ||
| aspect.h | ||
| bitmap_packer.c | ||
| bitmap_packer.h | ||
| cocoa_cb_common.swift | ||
| cocoa_common.h | ||
| cocoa_common.m | ||
| dither.c | ||
| dither.h | ||
| dr_helper.c | ||
| dr_helper.h | ||
| drm_atomic.c | ||
| drm_atomic.h | ||
| drm_common.c | ||
| drm_common.h | ||
| drm_prime.c | ||
| drm_prime.h | ||
| filter_kernels.c | ||
| filter_kernels.h | ||
| libmpv.h | ||
| libmpv_sw.c | ||
| present_sync.c | ||
| present_sync.h | ||
| vo.c | ||
| vo.h | ||
| vo_caca.c | ||
| vo_direct3d.c | ||
| vo_dmabuf_wayland.c | ||
| vo_drm.c | ||
| vo_gpu.c | ||
| vo_gpu_next.c | ||
| vo_image.c | ||
| vo_kitty.c | ||
| vo_lavc.c | ||
| vo_libmpv.c | ||
| vo_mediacodec_embed.c | ||
| vo_null.c | ||
| vo_rpi.c | ||
| vo_sdl.c | ||
| vo_sixel.c | ||
| vo_tct.c | ||
| vo_vaapi.c | ||
| vo_vdpau.c | ||
| vo_wlshm.c | ||
| vo_x11.c | ||
| vo_xv.c | ||
| w32_common.c | ||
| w32_common.h | ||
| wayland_common.c | ||
| wayland_common.h | ||
| win_state.c | ||
| win_state.h | ||
| x11_common.c | ||
| x11_common.h | ||