mirror of https://github.com/mpv-player/mpv
52536aaa7b
lavc_process() calls the receive/send callbacks, which mirror libavcodec's send/receive API. The receive API in particular can return both a status code and a frame. Normally, libavcodec is pretty explicit that it can't return both a frame and an error. But the receive callback does more stuff in addition (vd_lavc does hardware decoding fallbacks etc.). The previous commit shows an instance where this happened, and where it leaked a frame in this case. For robustness, check whether the frame is set first, i.e. trust it over the status code. Before this, it checked for an EOF status first. Hopefully is of no consequence otherwise. I made this change after testing everything (can someone implement a test suite which tests this exhaustively). |
||
|---|---|---|
| .. | ||
| f_auto_filters.c | ||
| f_auto_filters.h | ||
| f_autoconvert.c | ||
| f_autoconvert.h | ||
| f_decoder_wrapper.c | ||
| f_decoder_wrapper.h | ||
| f_demux_in.c | ||
| f_demux_in.h | ||
| f_hwtransfer.c | ||
| f_hwtransfer.h | ||
| f_lavfi.c | ||
| f_lavfi.h | ||
| f_output_chain.c | ||
| f_output_chain.h | ||
| f_swresample.c | ||
| f_swresample.h | ||
| f_swscale.c | ||
| f_swscale.h | ||
| f_utils.c | ||
| f_utils.h | ||
| filter.c | ||
| filter.h | ||
| filter_internal.h | ||
| frame.c | ||
| frame.h | ||
| user_filters.c | ||
| user_filters.h | ||