mirror of
https://github.com/mpv-player/mpv
synced 2025-01-25 00:53:22 +00:00
7d7ef05f10
I'm currently not convinced that the way the output_chain is handled as part of reconfiguration is correct. If there is an event requiring reconfiguration, such as toggling the use of hwdec, we currently do not ensure that the filter chain is fully drained first. This creates a situation where the filter chain is invalidated while the autoconvert's sub filter (that does the real work) still has a frame to process and pass on. As the autoconvert code calls mp_subfilter_drain_destroy(), it returns early to allow for draining before destroying the subfilter, but that means the subfilter is still present in its original configuration, and no actually draining is done before the existing filters reinitialise themselves. This leads to a situation where, if a hardware scaling filter is being used by autoconvert, that filter is still present and responds when told to reinitialise. But it cannot successfully reinitialise if the triggering event is disabling hw decoding, as the input frame to the filter will now be a software frame, so reinit fails, leading to total failure of the filter chain, which is a fatal error, and we exit. I think this was never noticed before, because I think it's not possible for the hwtransfer filter to be active in a situation where you can dynamically change the state such that the input or output formats of the output chain are invalidated. eg: If the autoconverter is activated because of `--vf=format=vaapi`, it is actually not possible to toggle hwdec off, as the explicit user filter ensure the hwdec is always present and active. So, my solution here is to destroy the sub filter, regardless of whether it needs draining or not. We simply have no opportunity to drain and reconfigure in the correct order, and we must consider the remaining frame in the filter as a casualty of the toggling process. I'm sure there is a more substantial rework of the output_chain reconfiguration process that could ensure draining before reconfiguration begins, but my ambitions do not currently extend that far. |
||
|---|---|---|
| .. | ||
| f_async_queue.c | ||
| f_async_queue.h | ||
| f_auto_filters.c | ||
| f_auto_filters.h | ||
| f_autoconvert.c | ||
| f_autoconvert.h | ||
| f_decoder_wrapper.c | ||
| f_decoder_wrapper.h | ||
| f_demux_in.c | ||
| f_demux_in.h | ||
| f_hwtransfer.c | ||
| f_hwtransfer.h | ||
| f_lavfi.c | ||
| f_lavfi.h | ||
| f_output_chain.c | ||
| f_output_chain.h | ||
| f_swresample.c | ||
| f_swresample.h | ||
| f_swscale.c | ||
| f_swscale.h | ||
| f_utils.c | ||
| f_utils.h | ||
| filter_internal.h | ||
| filter.c | ||
| filter.h | ||
| frame.c | ||
| frame.h | ||
| user_filters.c | ||
| user_filters.h | ||