mirror of
https://github.com/mpv-player/mpv
synced 2025-03-25 04:38:01 +00:00
39f7f83351
[motivation] Seeking on MacOS appears to be lagged when users connect to wireless audio output (airpods for example). This commit attempts to fix mpv-player/mpv#10270 [observation] 1. When using other media player (VLC to be exact) simultaneously, the lagging on seek disappear. We could guess that the AudioDevice is on some sort of "warm-up" state. See mpv-player/mpv#9243 for detailed description. 2. `AudioOutputUnitStart` takes significant longer time after each seek or pause/play when using wireless output devices compares to wired devices. [rationale] After investigate codes in ao_coreaudio.c, it appears that the the `stop` function was used as `ao_driver.reset` function. Therefore every seek and pause would call `AudioOutputUnitStop`. It turns out that `ao_driver.reset` function is used in `ao_reset`. And `ao_reset` function is used to clean up the state of current `ao` so I think `AudioUnitReset` is more proper than `AudioOutputUnitStop` under this semantics. Since ao_coreaudio use pull base mechanism, audio playback behaviors upon pause/seek could be handled by callback function (streaming silence when paused) so there is no need to stop AudioUnit when resetting. Therefore using `AudioUnitReset` as `ao_driver.reset` looks proper. Additionally, after using proper reset, the AudioUnit that represents hardware I/O devices doesn't need to be restart everytime seek/pause actions happen. Restarting wireless devices simply takes longer in MacOS which is the root cause of lagging observed by users when they seek or pause/play media. [method] Use `AudioUnitReset` for ao_driver.reset. |
||
|---|---|---|
| .. | ||
| ao_alsa.c | ||
| ao_audiotrack.c | ||
| ao_audiounit.m | ||
| ao_coreaudio_chmap.c | ||
| ao_coreaudio_chmap.h | ||
| ao_coreaudio_exclusive.c | ||
| ao_coreaudio_properties.c | ||
| ao_coreaudio_properties.h | ||
| ao_coreaudio_utils.c | ||
| ao_coreaudio_utils.h | ||
| ao_coreaudio.c | ||
| ao_jack.c | ||
| ao_lavc.c | ||
| ao_null.c | ||
| ao_openal.c | ||
| ao_opensles.c | ||
| ao_oss.c | ||
| ao_pcm.c | ||
| ao_pipewire.c | ||
| ao_pulse.c | ||
| ao_sdl.c | ||
| ao_sndio.c | ||
| ao_wasapi_changenotify.c | ||
| ao_wasapi_utils.c | ||
| ao_wasapi.c | ||
| ao_wasapi.h | ||
| ao.c | ||
| ao.h | ||
| buffer.c | ||
| internal.h | ||