1
0
mirror of https://github.com/mpv-player/mpv synced 2025-01-26 09:33:30 +00:00
mpv/video/out/wayland_common.h
Dudemanguy fb55ee99e3 wayland: don't set mouse pos on state change
Sway 1.5 started sending more pointer motion events to mpv which broke
the autohiding behavior. The cursor would appear again if you
fullscreened. Sway had a good reason to do this because certain
applications had inconsistencies between hardware cursor and software
cursor without rebasing on state changes[1]. So mpv needs to take this
special case into consideration.

Initially, simply checking mouse coordinates for changes was considered,
but this doesn't work. All coordinates are surface-local in wayland so
something can appear to move in the local coordinate space but not
globally. You're not allowed to know global mouse coordinates in
wayland, and we don't care about local coordinate changes in mpv so this
approach isn't viable.

Instead, let's just keep track of a local state change. If the toplevel
surface changes in some way (fullscreen, maximized, etc.), then just set
a bool that lets us ignore the mp_input_set_mouse_pos function. This
keeps the cursor from appearing simply because the state was changed
(i.e. fullscreening). For compositors that don't send pointer motion
events on a state change, this does technically mean that the initial
mp_input_set_mouse_pos is never set. In practice, this isn't a
noticeable difference though because moving a mouse generates a ton of
motion events so you'll immediately see it on the second motion event.

[1] https://github.com/swaywm/sway/issues/5594
2020-08-02 17:06:51 -05:00

159 lines
4.5 KiB
C

/*
* This file is part of mpv video player.
*
* mpv is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* mpv is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef MPLAYER_WAYLAND_COMMON_H
#define MPLAYER_WAYLAND_COMMON_H
#include <wayland-client.h>
#include <wayland-cursor.h>
#include <xkbcommon/xkbcommon.h>
#include "vo.h"
#include "input/event.h"
struct wayland_opts {
int disable_vsync;
int edge_pixels_pointer;
int edge_pixels_touch;
};
struct vo_wayland_sync {
int64_t ust;
int64_t msc;
int64_t sbc;
int64_t last_mp_time;
bool filled;
};
struct vo_wayland_output {
struct vo_wayland_state *wl;
uint32_t id;
struct wl_output *output;
struct mp_rect geometry;
int phys_width;
int phys_height;
int scale;
uint32_t flags;
double refresh_rate;
char *make;
char *model;
bool has_surface;
struct wl_list link;
};
struct vo_wayland_state {
struct mp_log *log;
struct vo *vo;
struct wl_display *display;
struct wl_shm *shm;
struct wl_compositor *compositor;
struct wl_registry *registry;
struct wayland_opts *opts;
struct m_config_cache *vo_opts_cache;
struct mp_vo_opts *vo_opts;
/* State */
struct mp_rect geometry;
struct mp_rect window_size;
int gcd;
int reduced_width;
int reduced_height;
bool configured;
bool frame_wait;
bool state_changed;
int wakeup_pipe[2];
int pending_vo_events;
int mouse_x;
int mouse_y;
int mouse_unscaled_x;
int mouse_unscaled_y;
int scaling;
int touch_entries;
int toplevel_width;
int toplevel_height;
uint32_t pointer_id;
int display_fd;
struct wl_callback *frame_callback;
struct wl_list output_list;
struct vo_wayland_output *current_output;
/* Shell */
struct wl_surface *surface;
struct xdg_wm_base *wm_base;
struct xdg_toplevel *xdg_toplevel;
struct xdg_surface *xdg_surface;
struct wp_presentation *presentation;
struct wp_presentation_feedback *feedback;
struct zxdg_decoration_manager_v1 *xdg_decoration_manager;
struct zxdg_toplevel_decoration_v1 *xdg_toplevel_decoration;
struct zwp_idle_inhibit_manager_v1 *idle_inhibit_manager;
struct zwp_idle_inhibitor_v1 *idle_inhibitor;
/* Presentation Feedback */
struct vo_wayland_sync *sync;
int sync_size;
int64_t user_sbc;
int64_t last_ust;
int64_t last_msc;
int64_t last_sbc;
int64_t last_sbc_mp_time;
int64_t vsync_duration;
int64_t last_skipped_vsyncs;
int64_t last_queue_display_time;
/* Input */
struct wl_seat *seat;
struct wl_pointer *pointer;
struct wl_touch *touch;
struct wl_keyboard *keyboard;
struct xkb_context *xkb_context;
struct xkb_keymap *xkb_keymap;
struct xkb_state *xkb_state;
/* DND */
struct wl_data_device_manager *dnd_devman;
struct wl_data_device *dnd_ddev;
struct wl_data_offer *dnd_offer;
enum mp_dnd_action dnd_action;
char *dnd_mime_type;
int dnd_mime_score;
int dnd_fd;
/* Cursor */
struct wl_cursor_theme *cursor_theme;
struct wl_cursor *default_cursor;
struct wl_surface *cursor_surface;
int allocated_cursor_scale;
bool cursor_visible;
};
int vo_wayland_init(struct vo *vo);
int vo_wayland_reconfig(struct vo *vo);
int vo_wayland_control(struct vo *vo, int *events, int request, void *arg);
int last_available_sync(struct vo_wayland_state *wl);
void vo_wayland_check_events(struct vo *vo);
void vo_wayland_uninit(struct vo *vo);
void vo_wayland_wakeup(struct vo *vo);
void vo_wayland_wait_events(struct vo *vo, int64_t until_time_us);
void vo_wayland_wait_frame(struct vo_wayland_state *wl);
void wayland_sync_swap(struct vo_wayland_state *wl);
void vo_wayland_sync_shift(struct vo_wayland_state *wl);
void queue_new_sync(struct vo_wayland_state *wl);
#endif /* MPLAYER_WAYLAND_COMMON_H */