mpv/sub
Dudemanguy 8ba6d8f7a9 sd_ass: fix use-after-free in ft->event_format
0b35b4c917 originally introduced sd_filter
to make a more general subtitle filter infrastructure. But when doing
so, it directly sets ft->event_format to ass_track->event_format in the
struct. The lifetime of ass_track and the sd_filter are not equivalent
which makes it easy to trigger undefined behavior. Notably, commit
cda8f1613f introduced assobjects_destroy
which can destroy ass_track anytime during runtime which means that the
string in ft->event_format is actually freed and should never be used.
Remedy this by simply doing a proper strdup when the filter inits with
ft as the parent so we avoid this scenario altogether. Fixex #13525.
2024-02-29 15:57:58 -06:00
..
ass_mp.c sub: add --sub-fonts-dir and --osd-fonts-dir options 2023-03-01 02:09:46 +00:00
ass_mp.h sub/ass_mp: filters/f_lavfi: forward declare mp_log 2023-09-21 14:40:11 +00:00
dec_sub.c player/sub: attempt to detect animated subtitles 2024-02-15 16:43:11 +00:00
dec_sub.h player/sub: avoid wasteful subtitle redraws 2024-02-15 16:43:11 +00:00
draw_bmp.c all: add missing repr assignments 2024-01-26 18:17:02 +02:00
draw_bmp.h csputils: replace mp_alpha_type with pl_alpha_mode 2024-01-22 14:54:55 +00:00
filter_jsre.c sub: jsre filter: abort init early on empty filter list 2022-06-09 14:38:24 +03:00
filter_regex.c sub: sub-filter-regex and jsre: support ass-to-plaintext 2021-08-05 21:32:22 +03:00
filter_sdh.c filter_sdh: optimize get_char_bytes 2024-01-15 16:05:17 +00:00
img_convert.c various: replace some OOM handling 2023-11-24 10:04:55 +01:00
img_convert.h sub: move RGBA scaling to vo_vaapi 2016-07-03 19:32:43 +02:00
lavc_conv.c sub/lavc_conv: properly fill avctx with codecpar values at init 2023-03-14 23:59:47 +02:00
meson.build build: remove outdated generated directory 2023-07-31 19:00:06 +00:00
osd.c ALL: use new mp_thread abstraction 2023-11-05 17:36:17 +00:00
osd.h sub: add --sub-fonts-dir and --osd-fonts-dir options 2023-03-01 02:09:46 +00:00
osd_font.otf osc: use custom symbols for window controls 2019-12-11 13:53:10 -08:00
osd_libass.c osd_libass: update the OSD bar's dent and border size 2024-02-26 16:01:21 +00:00
osd_state.h ALL: use new mp_thread abstraction 2023-11-05 17:36:17 +00:00
sd.h command: fix sub-seek while paused without a video 2024-02-23 21:37:22 +01:00
sd_ass.c sd_ass: fix use-after-free in ft->event_format 2024-02-29 15:57:58 -06:00
sd_lavc.c player/sub: avoid wasteful subtitle redraws 2024-02-15 16:43:11 +00:00