RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

demux_mkv: remove bad mkv_free() from 0ece360eea 

demuxer.c calls demuxer->close() even if opening failed. Thus the
mkv_free() call added in 0ece360eea ("demux_mkv: skip files faster
in ordered chapter file search") was wrong, and could cause a crash
from a double free if some data structures were allocated before the
opening attempt was aborted.
This commit is contained in:
Uoti Urpala 2011-08-19 21:10:10 +03:00
parent 3043beffab
commit f253de24af
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libmpdemux/demux_mkv.c
View File

@ -1701,7 +1701,6 @@ static int demux_mkv_open(demuxer_t *demuxer)
default:;
int res = read_header_element(demuxer, id, 0);
if (res == -2) {
mkv_free(demuxer);
return 0;
} else if (res < 1)
goto headersdone;