RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-03-22 03:08:33 +00:00
Code Issues Releases Wiki Activity

wayland: remove incorrect keepaspect check

Browse Source 
In the reconfig event, the keepaspect option was checked before setting
the window_size geometry to the new params obtained from the vo. This is
incorrect. If a user disabled keepaspect on wayland, the video's size
would not change on a reconfigure event (i.e. loading a new video in the
playlist with a different size). No other windowing backend (x11, win32,
etc.) behaves like this or uses keepaspect in its code like wayland did
in this case. Clearly, this is not correct. Such functionality should be
handled by a separate option entirely. Just remove this if statement.
This commit is contained in:
Dudemanguy 2021-10-26 13:21:08 -05:00
parent e6ab676d20
commit e4ee0c6ebc
1 changed files with 1 additions and 2 deletions

3
video/out/wayland_common.c
View File

@ -1793,8 +1793,7 @@ int vo_wayland_reconfig(struct vo *vo)
set_geometry(wl);
if (wl->vo_opts->keepaspect)
wl->window_size = wl->vdparams;
wl->window_size = wl->vdparams;
if (!wl->vo_opts->fullscreen && !wl->vo_opts->window_maximized)
wl->geometry = wl->window_size;