RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

vo_opengl: disable pbo by defaults for opengl-hq 

Too many problems.
This commit is contained in:
wm4 2015-12-19 16:26:36 +01:00
parent 47f2f554a3
commit cd24fdcd5a
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
DOCS/man/vo.rst
View File

@ -447,10 +447,12 @@ Available video output drivers are:
Note that this option never affects ``cscale``. Note that this option never affects ``cscale``.
``pbo`` ``pbo``
Enable use of PBOs. This is slightly faster, but can sometimes lead to Enable use of PBOs. On some drivers this can be faster, especially if
sporadic and temporary image corruption (in theory, because reupload the source video size is huge (e.g. so called "4K" video). On other
is not retried when it fails), and perhaps actually triggers slower drivers it might be slower or cause latency issues.
paths with drivers that don't support PBOs properly.
In theory, this can sometimes lead to sporadic and temporary image
corruption (because reupload is not retried when it fails).
``dither-depth=<N|no|auto>`` ``dither-depth=<N|no|auto>``
Set dither target depth to N. Default: no. Set dither target depth to N. Default: no.
@ -984,7 +986,7 @@ Available video output drivers are:
This is equivalent to:: This is equivalent to::
--vo=opengl:scale=spline36:cscale=spline36:dscale=mitchell:dither-depth=auto:correct-downscaling:sigmoid-upscaling:pbo:deband:es=no --vo=opengl:scale=spline36:cscale=spline36:dscale=mitchell:dither-depth=auto:correct-downscaling:sigmoid-upscaling:deband:es=no
Note that some cheaper LCDs do dithering that gravely interferes with Note that some cheaper LCDs do dithering that gravely interferes with
``opengl``'s dithering. Disabling dithering with ``dither-depth=no`` helps. ``opengl``'s dithering. Disabling dithering with ``dither-depth=no`` helps.

1
video/out/opengl/video.c
View File

@ -373,7 +373,6 @@ const struct gl_video_opts gl_video_opts_hq_def = {
.background = {0, 0, 0, 255}, .background = {0, 0, 0, 255},
.gamma = 1.0f, .gamma = 1.0f,
.blend_subs = 0, .blend_subs = 0,
.pbo = 1,
.deband = 1, .deband = 1,
.prescale_passes = 1, .prescale_passes = 1,
.prescale_downscaling_threshold = 2.0f, .prescale_downscaling_threshold = 2.0f,