RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-04-11 04:01:31 +00:00
Code Issues Releases Wiki Activity

path: fix undefined behavior

Browse Source 
The homepath variable was static, and its value was set to a stack
buffer. This means a second invocation of the function would trigger
undefined behavior. Moreover the stack buffer always went out of scope
before homepath was used.
This commit is contained in:
wm4 2013-09-18 17:02:31 +02:00
parent bb4ea8bb3e
commit b97d10a839
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mpvcore/path.c
View File

@ -78,12 +78,12 @@ char *mp_find_config_file(const char *filename)
char *mp_find_user_config_file(const char *filename) char *mp_find_user_config_file(const char *filename)
{ {
char *homedir = NULL, *buff = NULL; char *homedir = NULL, *buff = NULL;
static char *homepath = NULL; char *homepath = NULL;
#ifdef __MINGW32__ #ifdef __MINGW32__
char *config_dir = "mpv"; char *config_dir = "mpv";
char buf[MAX_PATH];
if (homepath == NULL) { if (homepath == NULL) {
char buf[MAX_PATH];
if (SHGetFolderPathA(NULL, CSIDL_LOCAL_APPDATA|CSIDL_FLAG_CREATE, NULL, if (SHGetFolderPathA(NULL, CSIDL_LOCAL_APPDATA|CSIDL_FLAG_CREATE, NULL,
SHGFP_TYPE_CURRENT, buf) == S_OK) { SHGFP_TYPE_CURRENT, buf) == S_OK) {