RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

video: do not buffer extra frames with VO_CAP_NORETAIN outputs 

This fixes playback stalls on some mediacodec hardware decoders,
which expect that frame buffers will be rendered and returned back
to the decoder as soon as possible.

Specifically, the issue was observed on an NVidia SHIELD Android TV,
only when playing an H264 sample which switched between interlaced
and non-interlaced frames. On an interlacing change, the decoder
expects all outstanding frames would be returned to it before it
would emit any new frames. Since a single extra frame always remained
buffered by mpv, playback would stall. After this commit, no extra
frames are buffered by mpv when using vo_mediacodec_embed.
This commit is contained in:
Aman Gupta 2018-02-15 19:57:34 -08:00 committed by Kevin Mitchell
parent 288ed66a35
commit b67d2ede67
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
player/video.c
View File

@ -408,6 +408,9 @@ static int get_req_frames(struct MPContext *mpctx, bool eof)
if (eof)
return 1;
if (mpctx->video_out->driver->caps & VO_CAP_NORETAIN)
return 1;
// On the first frame, output a new frame as quickly as possible.
// But display-sync likes to have a correct frame duration always.
if (mpctx->video_pts == MP_NOPTS_VALUE)