From b59ac04db95e1237d879ce1aa6cb720a218c83e2 Mon Sep 17 00:00:00 2001 From: nanahi <130121847+na-na-hi@users.noreply.github.com> Date: Mon, 10 Jun 2024 11:42:38 -0400 Subject: [PATCH] DOCS/man/options: clarify subtitle scale options The current documentation of sub-scale-by-window and sub-scale-with-window doesn't sufficiently convey what these options do exactly. Specifically, the described effects of disabling one option is only true when the other option is not disabled. The "clarification" of sub-scale-with-window option only adds more confusion, when the effect of that option is already told in more detail before (it scaled with window instead of video). Clarify this by listing the effects of all combinations of these options. --- DOCS/man/options.rst | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 7a39be15f5..5d6ee4008a 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -2387,27 +2387,28 @@ Subtitles ``--sub-scale-by-window=`` Whether to scale subtitles with the window size (default: yes). If this is - disabled, changing the window size won't change the subtitle font size. + disabled while ``--sub-scale-with-window`` is set to yes, changing the window + size won't change the subtitle font size. Affects plain text subtitles only (or ASS if ``--sub-ass-override`` is set high enough). ``--sub-scale-with-window=`` - Make the subtitle font size relative to the window, instead of the video. - This is useful if you always want the same font size, even if the video - doesn't cover the window fully, e.g. because screen aspect and window - aspect mismatch (and the player adds black bars). - - Default: yes. - - This option is misnamed. The difference to the confusingly similar sounding - option ``--sub-scale-by-window`` is that ``--sub-scale-with-window`` still - scales with the approximate window size, while the other option disables - this scaling. + Make the subtitle font size relative to the window (default: yes). If this is + disabled while ``--sub-scale-by-window`` is set to yes, the subtitle font + size is scaled relative to the video size instead. Affects plain text subtitles only (or ASS if ``--sub-ass-override`` is set high enough). + .. note:: + + By default, the subtitle font size is scaled with the window size. + To make the font size constant, set only ``--sub-scale-by-window`` to no. + To make the font size scale with video size instead, set only + ``--sub-scale-with-window`` to no. + It's not meaningful to set both options to no. + ``--sub-ass-scale-with-window=`` Like ``--sub-scale-with-window``, but affects subtitles in ASS format only. Like ``--sub-scale``, this can break ASS subtitles.