From 6e2ac4d40add2ad316ed312933e51f58a7a7650c Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 27 Nov 2013 21:12:09 +0100 Subject: [PATCH] af_lavi: actually free the filter graph on uninit This was a memory leak. Also remove the AF_CONTROL_COMMAND_LINE code, which was inactive. (It's never called if the new option parser is used.) --- audio/filter/af_lavfi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/audio/filter/af_lavfi.c b/audio/filter/af_lavfi.c index 57a1055149..6ef5bf6f80 100644 --- a/audio/filter/af_lavfi.c +++ b/audio/filter/af_lavfi.c @@ -202,11 +202,6 @@ static int control(struct af_instance *af, int cmd, void *arg) return mp_audio_config_equals(in, &orig_in) ? AF_OK : AF_FALSE; } - case AF_CONTROL_COMMAND_LINE: { - talloc_free(p->cfg_graph); - p->cfg_graph = talloc_strdup(p, (char *)arg); - return AF_OK; - } } return AF_UNKNOWN; } @@ -280,6 +275,7 @@ static struct mp_audio *play(struct af_instance *af, struct mp_audio *data) static void uninit(struct af_instance *af) { + destroy_graph(af); } static int af_open(struct af_instance *af)