x11: comment about gravity

The window "gravity" influences how placement interacts with WM added
borders (i.e. from decorations). This is probably what the code removed
in commit c14721c8 was about.

In theory, we'd probably want to set the gravity depending on the
relative placement requested by the user (so that it's possible to line
up the top/left video pixel with the monitor corner, as well as the
bottom/right pixel - but that would be too complicated, and who cares
after all?).

I'm also not sure whether CenterGravity really uses the top/left corner
as reference point (instead of making coordinates relative to the window
center), but empirically it's correct.
This commit is contained in:
wm4 2014-05-17 14:26:49 +02:00
parent 0e579f8439
commit 5a1bf25523
1 changed files with 4 additions and 0 deletions

View File

@ -933,8 +933,12 @@ static void vo_x11_sizehint(struct vo *vo, struct mp_rect rc, bool override_pos)
hint->flags |= PMinSize;
hint->min_width = hint->min_height = 4;
// This will use the top/left corner of the window for positioning, instead
// of the top/left corner of the client. _NET_MOVERESIZE_WINDOW could be
// used to get a different reference point, while keeping gravity.
hint->flags |= PWinGravity;
hint->win_gravity = CenterGravity;
XSetWMNormalHints(x11->display, x11->window, hint);
XFree(hint);
}