1
0
mirror of https://github.com/mpv-player/mpv synced 2025-03-20 02:09:52 +00:00

DOCS/contribute.md: Add guideline for pull requests

This commit is to prevent changes being merged into upstream, without
being known if it is tested or not.

Signed-off-by: wm4 <wm4@nowhere>
This commit is contained in:
robin007bond 2015-04-13 14:51:03 +02:00 committed by wm4
parent 5b1c3e4b50
commit 3b2cc79d2f

View File

@ -14,6 +14,9 @@ Sending patches
``git format-patch``. diffs posted as pastebins (especially if the http link ``git format-patch``. diffs posted as pastebins (especially if the http link
returns HTML) just cause extra work for everyone, because they lack commit returns HTML) just cause extra work for everyone, because they lack commit
message and authorship information. message and authorship information.
- When creating pull requests, be sure to test your changes. If you didn't, please
say so in the pull request message.
- Write informative commit messages. Use present tense to describe the - Write informative commit messages. Use present tense to describe the
situation with the patch applied, and past tense for the situation before situation with the patch applied, and past tense for the situation before
the change. the change.