RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-04-11 04:01:31 +00:00
Code Issues Releases Wiki Activity

sub/ass_mp: reduce libass fontselect log spam

Browse Source 
This prevents "fontselect" missing glyph messages from showing up
at the default loglevel after it is shown once. After that they now
only show up at verbose level and up.

These messages can be generated repeatedly every time the sub is
rendered in certain situations, resulting in log spam.
This commit is contained in:
nanahi 2023-12-30 12:47:18 -05:00
parent a16bad4004
commit 201c63253c
No known key found for this signature in database
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sub/ass_mp.c
View File

@ -123,10 +123,24 @@ static const int map_ass_level[] = {
static void message_callback(int level, const char *format, va_list va, void *ctx)
{
static bool missing_glyph_warned;
struct mp_log *log = ctx;
if (!log)
return;
level = map_ass_level[level];
// "fontselect" missing glyph messages are treated as "warnings" by libass.
// However, they're highly disruptive as these messages can be genereated
// repeatedly every time the sub is rendered, creating log spam.
// Unfortunately, libass also has some other useful messages at the same
// loglevel, so use strncmp to check the presence of fontselect messages.
// Reduce the log spam by changing the log level after the first warning.
if (level == MSGL_INFO && strncmp(format, "fontselect: failed to find", 26) == 0) {
if (!missing_glyph_warned) {
missing_glyph_warned = true;
} else {
level = MSGL_V;
}
}
mp_msg_va(log, level, format, va);
// libass messages lack trailing \n
mp_msg(log, level, "\n");