RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

player: check if file is URL before attempting to get mtime 

I noticed an oversight when using ytdl-hook -- if the path is a URL, we
try to `stat()` it, which obviously doesn't work. To mitigate that,
don't check or update mtimes for URLs.
This commit is contained in:
Chris Down 2020-01-18 22:39:08 +00:00 committed by wm4
parent b316534902
commit 1ae17074bd
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
player/configfiles.c
View File

@ -319,7 +319,8 @@ static void write_redirect(struct MPContext *mpctx, char *path)
fclose(file);
}
if (mpctx->opts->position_check_mtime && !copy_mtime(path, conffile))
if (mpctx->opts->position_check_mtime &&
!mp_is_url(bstr0(path)) && !copy_mtime(path, conffile))
MP_WARN(mpctx, "Can't copy mtime from %s to %s\n", path, conffile);
talloc_free(conffile);
@ -381,6 +382,7 @@ void mp_write_watch_later_conf(struct MPContext *mpctx)
fclose(file);
if (mpctx->opts->position_check_mtime &&
!mp_is_url(bstr0(cur->filename)) &&
!copy_mtime(cur->filename, conffile))
{
MP_WARN(mpctx, "Can't copy mtime from %s to %s\n", cur->filename,
@ -428,7 +430,8 @@ void mp_load_playback_resume(struct MPContext *mpctx, const char *file)
return;
char *fname = mp_get_playback_resume_config_filename(mpctx, file);
if (fname && mp_path_exists(fname)) {
if (mpctx->opts->position_check_mtime && !check_mtime(file, fname)) {
if (mpctx->opts->position_check_mtime &&
!mp_is_url(bstr0(file)) && !check_mtime(file, fname)) {
talloc_free(fname);
return;
}