1
0
mirror of https://github.com/mpv-player/mpv synced 2025-03-21 10:51:51 +00:00

input: improve some comments

I have the feeling some of these were written before everything was
changed all over again.
This commit is contained in:
wm4 2013-12-01 17:34:43 +01:00
parent b5d7c95e36
commit 071ae5613f

View File

@ -1484,7 +1484,7 @@ static void remove_key_down(struct input_ctx *ictx, int code)
} }
} }
// Whether a command can deal with redundant key up events. // Whether a command shall be sent on both key down and key up events.
static bool key_updown_ok(enum mp_command_type cmd) static bool key_updown_ok(enum mp_command_type cmd)
{ {
switch (cmd) { switch (cmd) {
@ -1595,9 +1595,9 @@ static void interpret_key(struct input_ctx *ictx, int code, double scale)
if (!cmd) if (!cmd)
return; return;
// Prevent redundant key-down events from being added to the queue. In some // Don't emit a command on key-down if the key is designed to emit commands
// cases (like MP_CMD_SEEK commands), duplicated events might severely // on key-up (like mouse buttons). Also, if the command specifically should
// confuse the frontend. // be sent both on key down and key up, still emit the command.
if (cmd->key_up_follows && !key_updown_ok(cmd->id)) { if (cmd->key_up_follows && !key_updown_ok(cmd->id)) {
talloc_free(cmd); talloc_free(cmd);
return; return;