2001-10-07 16:34:47 +00:00
|
|
|
Sending patches:
|
|
|
|
|
~~~~~~~~~~~~~~~~
|
2002-05-16 09:00:59 +00:00
|
|
|
Note: We know these rules are hard, but it's hard to maintain such a
|
2001-10-07 16:34:47 +00:00
|
|
|
big and complex project, so you should accept our rules. We have no
|
|
|
|
|
time for fixing buggy, broken or old patches!
|
|
|
|
|
|
2002-05-16 09:00:59 +00:00
|
|
|
1. Always make patches for the CVS version.
|
2001-10-07 16:34:47 +00:00
|
|
|
We do not accept patches for old versions or releases.
|
|
|
|
|
|
2002-05-16 09:00:59 +00:00
|
|
|
2. Make unified diffs ('diff -Naur' or 'cvs diff -u').
|
2001-10-07 16:34:47 +00:00
|
|
|
|
2002-05-16 09:00:59 +00:00
|
|
|
3. Test the functionality of your patch. We'll *refuse* it if it breaks
|
2001-10-07 16:34:47 +00:00
|
|
|
something, even if it extends other features!
|
|
|
|
|
|
2002-05-16 09:00:59 +00:00
|
|
|
4. Read your patch. We'll *refuse* it if it changes indentation of the
|
|
|
|
|
code or if it does tab/space conversion or other cosmetical changes!
|
2001-10-07 16:34:47 +00:00
|
|
|
|
2002-05-16 09:00:59 +00:00
|
|
|
5. Comment parts that really need it (tricky side-effects etc).
|
|
|
|
|
Commenting trivial code not required. Comments must be English!
|
2001-10-07 16:34:47 +00:00
|
|
|
|
|
|
|
|
6. Do not ask for CVS write access at first time. If you contributed
|
|
|
|
|
1 or more nice, acceptable patches and they need maintaining or
|
2002-05-16 09:00:59 +00:00
|
|
|
you want to be an mplayer developer, you'll get CVS write access.
|
2001-10-07 16:34:47 +00:00
|
|
|
|
|
|
|
|
7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic)
|
|
|
|
|
and send your patch there as base64-encoded attachment (use gzip or
|
2002-01-17 00:26:40 +00:00
|
|
|
bzip2 *only* if it's really big or if you know that your mailer messes
|
2002-05-16 09:00:59 +00:00
|
|
|
up (reformats) text attachments).
|
2002-01-17 00:26:40 +00:00
|
|
|
Subject line should be: '[PATCH] very short description of the patch'.
|
2002-05-16 09:00:59 +00:00
|
|
|
In the mail, describe in a few sentences what you change and why.
|
2002-01-17 00:26:40 +00:00
|
|
|
If you made independent changes, try to send them as separate patches.
|
2001-10-07 16:34:47 +00:00
|
|
|
|
|
|
|
|
Thank you!
|
|
|
|
|
|
|
|
|
|
A'rpi
|
