From a679fc63216639462fb6cc56e93ed8a65af64653 Mon Sep 17 00:00:00 2001
From: aler9 <46489434+aler9@users.noreply.github.com>
Date: Sat, 28 Jan 2023 16:00:53 +0100
Subject: [PATCH] rpicamera: set default denoise mode to "off"

this improves performance for most users.
---
 internal/rpicamera/exe/camera.cpp | 8 ++++----
 rtsp-simple-server.yml            | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/internal/rpicamera/exe/camera.cpp b/internal/rpicamera/exe/camera.cpp
index d960f172..79c78aa5 100644
--- a/internal/rpicamera/exe/camera.cpp
+++ b/internal/rpicamera/exe/camera.cpp
@@ -275,14 +275,14 @@ bool camera_start(camera_t *cam) {
     ctrls.set(controls::AwbMode, awb_mode);
 
     int denoise_mode;
-    if (strcmp(camp->params->denoise, "off") == 0) {
-        denoise_mode = controls::draft::NoiseReductionModeOff;
-    } else if (strcmp(camp->params->denoise, "cdn_off") == 0) {
+    if (strcmp(camp->params->denoise, "cdn_off") == 0) {
         denoise_mode = controls::draft::NoiseReductionModeMinimal;
     } else if (strcmp(camp->params->denoise, "cdn_hq") == 0) {
         denoise_mode = controls::draft::NoiseReductionModeHighQuality;
-    } else {
+    } else if (strcmp(camp->params->denoise, "cdn_fast") == 0) {
         denoise_mode = controls::draft::NoiseReductionModeFast;
+    } else {
+        denoise_mode = controls::draft::NoiseReductionModeOff;
     }
     ctrls.set(controls::draft::NoiseReductionMode, denoise_mode);
 
diff --git a/rtsp-simple-server.yml b/rtsp-simple-server.yml
index fc1e52b1..efe02f4b 100644
--- a/rtsp-simple-server.yml
+++ b/rtsp-simple-server.yml
@@ -299,8 +299,8 @@ paths:
     # values: auto, incandescent, tungsten, fluorescent, indoor, daylight, cloudy, custom
     rpiCameraAWB: auto
     # denoise operating mode.
-    # values: auto, off, cdn_off, cdn_fast, cdn_hq
-    rpiCameraDenoise: auto
+    # values: off, cdn_off, cdn_fast, cdn_hq
+    rpiCameraDenoise: "off"
     # fixed shutter speed, in microseconds.
     rpiCameraShutter: 0
     # metering mode of the AEC/AGC algorithm.