From f92a44ecfac3ff40dba58f7812c50ed5fd5e58f4 Mon Sep 17 00:00:00 2001
From: Thomas Schoebel-Theuer <tst@1und1.de>
Date: Thu, 21 Jul 2022 12:35:09 +0200
Subject: [PATCH] copy: safeguard against strange compiler warnings

---
 kernel/mars_copy.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/kernel/mars_copy.c b/kernel/mars_copy.c
index 04151830..9801f606 100644
--- a/kernel/mars_copy.c
+++ b/kernel/mars_copy.c
@@ -524,7 +524,9 @@ restart:
 		_clear_mref(brick, index, 0);
 		next_state = COPY_STATE_START;
 		/* fallthrough */
+		goto label_COPY_STATE_START;
 	case COPY_STATE_START:
+	label_COPY_STATE_START:
 		/* This is the relgular starting state.
 		 * It must be zero, automatically entered via memset()
 		 */
@@ -561,7 +563,9 @@ restart:
 
 		next_state = COPY_STATE_START2;
 		/* fallthrough */
+		goto label_COPY_STATE_START2;
 	case COPY_STATE_START2:
+	label_COPY_STATE_START2:
 		status = _make_mref(brick, index, 1, NULL,
 				    pos, brick->copy_end,
 				    _make_flags(true, true));
@@ -572,15 +576,19 @@ restart:
 		}
 		next_state = COPY_STATE_READ2;
 		/* fallthrough */
+		goto label_COPY_STATE_READ2;
 	case COPY_STATE_READ2:
+	label_COPY_STATE_READ2:
 		if (READ_ONCE(st->active[1])) {
 			/* idempotence: wait by unchanged state */
 			goto idle;
 		}
 		/* wait for both mrefs to appear */
 		/* fallthrough */
+		goto label_COPY_STATE_READ3;
 	case COPY_STATE_READ1:
 	case COPY_STATE_READ3:
+	label_COPY_STATE_READ3:
 		if (READ_ONCE(st->active[0])) {
 			/* idempotence: wait by unchanged state */
 			goto idle;
@@ -644,7 +652,9 @@ restart:
 		}
 		next_state = COPY_STATE_WRITE;
 		/* fallthrough */
+		goto label_COPY_STATE_WRITE;
 	case COPY_STATE_WRITE:
+	label_COPY_STATE_WRITE:
 		if (is_write_limited(brick))
 			goto idle;
 		/* Obey ordering to get a strict "append" behaviour.
@@ -703,7 +713,9 @@ restart:
 			st->writeout = true;
 		next_state = COPY_STATE_WRITTEN;
 		/* fallthrough */
+		goto label_COPY_STATE_WRITTEN;
 	case COPY_STATE_WRITTEN:
+	label_COPY_STATE_WRITTEN:
 		if (READ_ONCE(st->active[1])) {
 			/* idempotence: wait by unchanged state */
 			MARS_IO("irrelevant\n");
@@ -721,12 +733,16 @@ restart:
 		}
 		next_state = COPY_STATE_CLEANUP;
 		/* fallthrough */
+		goto label_COPY_STATE_CLEANUP;
 	case COPY_STATE_CLEANUP:
+	label_COPY_STATE_CLEANUP:
 		_clear_mref(brick, index, 1);
 		_clear_mref(brick, index, 0);
 		next_state = COPY_STATE_FINISHED;
 		/* fallthrough */
+		goto label_COPY_STATE_FINISHED;
 	case COPY_STATE_FINISHED:
+	label_COPY_STATE_FINISHED:
 		/* Indicate successful completion by remaining in this state.
 		 * Restart of the finite automaton must be done externally.
 		 */