From a43181a84f81b814313c53dfa39706d1ad837f97 Mon Sep 17 00:00:00 2001 From: Thomas Schoebel-Theuer Date: Thu, 6 Mar 2014 08:52:15 +0100 Subject: [PATCH] marsadm: fix split brain detection --- userspace/marsadm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/userspace/marsadm b/userspace/marsadm index a0469e36..912f9b87 100755 --- a/userspace/marsadm +++ b/userspace/marsadm @@ -657,6 +657,23 @@ sub detect_splitbrain { } } } + if ($ok) { # check for duplicate logfiles + my @logs = glob("$mars/resource-$res/log-*"); + my $oldnr = -1; + foreach my $path (sort(@logs)) { + $path =~ m:/log-([0-9]+):; + my $nr = $1; + if ($nr == $oldnr) { + $ok = 0; + lwarn "SPLIT BRAIN at '$res' detected: duplicate logfile number $nr\n"; + lwarn "hint: first resolve split brain by 'leave-resource' or 'invalidate'\n"; + lwarn "hint: if this does not help, try cleanup via 'log-purge-all'\n"; + lwarn "hint: if this does not help, try 'log-purge-all --force'\n"; + last; + } + $oldnr = $nr; + } + } $detected_splits{$res} = $ok; return $ok; }