mirror of https://git.ffmpeg.org/ffmpeg.git
f80b2ce9fa
Converting from an integer to HWND (which is a pointer) requires
an explicit cast, otherwise Clang errors out like this:
src/libavdevice/gdigrab.c:280:14: error: incompatible integer to pointer conversion assigning to 'HWND' (aka 'struct HWND__ *') from 'long' [-Wint-conversion]
280 | hwnd = strtol(name, &p, 0);
| ^ ~~~~~~~~~~~~~~~~~~~
(With GCC and MSVC, this was a mere warning, but with recent Clang,
this is an error.)
After adding a cast, all compilers also warn something like this:
src/libavdevice/gdigrab.c:280:16: warning: cast to 'HWND' (aka 'struct HWND__ *') from smaller integer type 'long' [-Wint-to-pointer-cast]
280 | hwnd = (HWND) strtol(name, &p, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
On Windows, long types are 32 bit, so to get a usable pointer, we
need to use long long. And interpret it as unsigned long long
while at it - i.e. using strtoull.
Finally, right above it, the code triggered the following warning:
src/libavdevice/gdigrab.c:278:15: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
278 | char *p;
| ^
Signed-off-by: Martin Storsjö <martin@martin.st>
|
||
|---|---|---|
| .. | ||
| tests | ||
| .gitignore | ||
| Makefile | ||
| alldevices.c | ||
| alsa.c | ||
| alsa.h | ||
| alsa_dec.c | ||
| alsa_enc.c | ||
| android_camera.c | ||
| audiotoolbox.m | ||
| avdevice.c | ||
| avdevice.h | ||
| avdeviceres.rc | ||
| avfoundation.m | ||
| bktr.c | ||
| caca.c | ||
| ccfifo.c | ||
| decklink_common.cpp | ||
| decklink_common.h | ||
| decklink_common_c.h | ||
| decklink_dec.cpp | ||
| decklink_dec.h | ||
| decklink_dec_c.c | ||
| decklink_enc.cpp | ||
| decklink_enc.h | ||
| decklink_enc_c.c | ||
| dshow.c | ||
| dshow_capture.h | ||
| dshow_common.c | ||
| dshow_crossbar.c | ||
| dshow_enummediatypes.c | ||
| dshow_enumpins.c | ||
| dshow_filter.c | ||
| dshow_pin.c | ||
| fbdev_common.c | ||
| fbdev_common.h | ||
| fbdev_dec.c | ||
| fbdev_enc.c | ||
| file_open.c | ||
| gdigrab.c | ||
| iec61883.c | ||
| internal.h | ||
| jack.c | ||
| kmsgrab.c | ||
| lavfi.c | ||
| libavdevice.v | ||
| libcdio.c | ||
| libdc1394.c | ||
| openal-dec.c | ||
| opengl_enc.c | ||
| opengl_enc_shaders.h | ||
| oss.c | ||
| oss.h | ||
| oss_dec.c | ||
| oss_enc.c | ||
| pulse_audio_common.c | ||
| pulse_audio_common.h | ||
| pulse_audio_dec.c | ||
| pulse_audio_enc.c | ||
| reverse.c | ||
| sdl2.c | ||
| sndio.c | ||
| sndio.h | ||
| sndio_dec.c | ||
| sndio_enc.c | ||
| timefilter.c | ||
| timefilter.h | ||
| utils.c | ||
| v4l2-common.c | ||
| v4l2-common.h | ||
| v4l2.c | ||
| v4l2enc.c | ||
| version.c | ||
| version.h | ||
| version_major.h | ||
| vfwcap.c | ||
| xcbgrab.c | ||
| xv.c | ||